Skip to content
Snippets Groups Projects

Issue #3348890: Drupal 10 and CKEditor5 compatibility

2 unresolved threads

Merge request reports

Approval is optional

Closed by Marcelo VaniMarcelo Vani 1 year ago (Nov 22, 2023 2:16am UTC)

Merge details

  • The changes were not merged into 8.x-1.x.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
7 7 js/paragraphs_inline_entity_form.dialog.js: {}
8 8 dependencies:
9 9 - core/jquery
10
11 ckeditor5:
12 remote: https://cdn.ckeditor.com/ckeditor5/29.0.0/classic/ckeditor.js
  • Comment on lines +10 to +12

    These lines resulted in:

    [error] 1900#1900: *3690 FastCGI sent in stderr: "PHP message: Uncaught PHP Exception Drupal\Core\Asset\Exception\IncompleteLibraryDefinitionException: "Incomplete library definition for definition 'ckeditor5' in extension 'paragraphs_inline_entity_form'" at /var/www/html/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php line 135" while reading response header from upstream

    Removing them stopped the issue. This was on D10 with ckeditor 4 and 5 enabled

    Edited by Max Pogonowski
  • Max Pogonowski changed this line in version 4 of the diff

    changed this line in version 4 of the diff

  • Please register or sign in to reply
  • 1 1 name: Paragraphs Inline Entity Form
    2 2 type: module
    3 3 description: 'Paragraphs selector for Entity Browser and integration with Entity Embed Wysiwyg'
    4 core_version_requirement: ^8 || ^9
    4 core_version_requirement: ^8 || ^9 || ^10
    5 5 package: Paragraphs
    6 6 dependencies:
    7 7 - drupal:ckeditor
  • Max Pogonowski added 1 commit

    added 1 commit

    • 83a4a2d7 - address unresolved threads re library dependencies

    Compare with previous version

  • I partially merged this PR in 8ff46759 as this PR is not currently mergeable.

  • closed

  • Please register or sign in to reply
    Loading