Skip to content
Snippets Groups Projects

Issue #2833934: Introduce client side remove, with confirmation? and undo

Open Issue #2833934: Introduce client side remove, with confirmation? and undo
issue/paragraphs-2833934:2833934-introduce-client-side into 8.x-1.x
Open Brad Treloar requested to merge issue/paragraphs-2833934:2833934-introduce-client-side into 8.x-1.x

Merge request reports

Members who can merge are allowed to add commits.
Approval is optional
Ready to merge by members who can write to the target branch.
  • The source branch is 49 commits behind the target branch.
  • 1 commit will be added to 8.x-1.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brad Treloar
    Brad Treloar @bradtreloar ·
    Author

    This change makes a couple of tweaks to the patch in post #5:

    • Apply the visually-hidden class directly to the widget element instead of wrapping it in a visually-hidden div.
      • To add the wrapper div, jQuery detaches the widget element from the DOM and this breaks the CKEditor behaviours attached to any WYSIWYG fields in the widget.
    • Only trigger the first Remove button inside the field item wrapper. (There may be subform inside the paragraph widget with their own Remove buttons, which should not be triggered.)
    • Some minor refactoring and cleanup.
  • Sourabh Jain added 1 commit

    added 1 commit

    • 8d380b82 - Resolved once is not a function error.

    Compare with previous version

Please register or sign in to reply