Skip to content
Snippets Groups Projects
Commit ed46536d authored by Oliver Davies's avatar Oliver Davies
Browse files

Issue #2915320: Add missing permission

parent 53d12d6b
No related branches found
No related tags found
No related merge requests found
......@@ -66,8 +66,8 @@ function override_node_options_entity_field_access_alter(array &$grants, array $
$grants[':default'] = AccessResult::allowedIfHasPermissions(
$context['account'],
[
// 'override all revision log entry',
"override $bundle revision log entry",
'enter all revision log entry',
"enter $bundle revision log entry",
],
'OR'
);
......
......@@ -55,6 +55,10 @@ class OverrideNodeOptionsPermissions {
'title' => $this->t('Override all revision option.'),
];
$permissions['enter all revision log entry'] = [
'title' => $this->t('Enter revision log entries for all node types.'),
];
$permissions['override all authored by option'] = [
'title' => $this->t('Override all authored by option.'),
];
......@@ -92,7 +96,7 @@ class OverrideNodeOptionsPermissions {
'title' => $this->t("Override %type_name revision option.", ["%type_name" => $name]),
];
$permissions["override $id revision log entry"] = [
$permissions["enter $id revision log entry"] = [
'title' => $this->t("Enter %type_name revision log entry.", ["%type_name" => $name]),
];
......
......@@ -162,21 +162,29 @@ class NodeFormTest extends BrowserTestBase {
$specific_user = $this->drupalCreateUser([
'create page content',
'edit any page content',
'enter page revision log entry',
'override page revision option',
]);
$general_user = $this->drupalCreateUser([
'create page content',
'edit any page content',
'enter all revision log entry',
'override all revision option',
]);
$fields = ['revision' => TRUE];
$fields = [
'revision' => TRUE,
'revision_log' => TRUE,
];
foreach ([$specific_user, $general_user] as $user) {
$this->drupalLogin($user);
$this->drupalPostForm('node/' . $this->node->id() . '/edit', $fields, t('Save'));
$this->drupalPostForm('node/' . $this->node->id() . '/edit', [
'revision' => TRUE,
'revision_log[0][value]' => '',
], t('Save'));
$this->assertNodeFieldsUpdated($this->node, [], $this->node->getRevisionId());
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment