Issue #3623411: Follow kessai: name a payment account by its uuid, and call it an account

Frank Mablyrequested to merge
issue/orchestra-3623411:3623411-follow-kessai-a into 1.x

kessai renames getAvailableGateways() to getAvailableAccounts(). orchestra_payment calls it when the payment step builds its configuration form, so that form fatals the moment the rename lands on a site that has both installed.

These three land together, in any order but within the same deploy:

kessai is pre-1.0 and deletes rather than deprecates, so there is no alias to soften the gap.

What changes

  • The call site, so nothing fatals.
  • The label, from "Gateway override" to "Account override", and its French translation. That is what it overrides: a payment account, a contract at a provider. The prose beside it already said so.

What does not

The setting's stored key stays gateway. It moves when the value does, with the second half of the kessai issue: renaming it needs a migration, and one migration is better than two.

Merge request reports