Issue #3620617: Name the access check checkActionAccess() in the comments that call it actionAccess
Follow-up to !428 (merged), found while auditing it: actionAccess is written in 17 comments across 6 submodules, and no such method exists in Orchestra. The access check is checkActionAccess() (WorkItemManagerInterface); actionAccess() belongs to the unrelated Flag module.
Comments only, no behavior change. Each affected paragraph was rewrapped as a whole so no sentence is left broken across a wrap.
Files touched: orchestra_content (2), orchestra_delegation (1), orchestra_inbox (1), orchestra_interaction (3), orchestra_interaction_task (4), orchestra_interaction_webform (2).
Note this is distinct from the "three docblocks name a method that does not exist" item on #3620621, which names InteractionController.php and a test; that file contains no actionAccess at all.
Not included here, and still unowned, are three other findings from the same audit:
DefinitionResolver.php:74,:141andProcessInstanceInterface.php:54describe an instance falling back to the live workflow because "its snapshot has been pruned", whichpruneOrphans()prevents: it skips every revision an instance references. That docblock is what led !428 (merged) to state the same untrue thing indocs/versioning.mdbefore the audit caught it.getProcessInstanceAttachments()names two unrelated things: files to deliver onOrchestraNotificationEvent, and content bound to an instance onAttachmentManagerInterface.- In
example_quorum.ymlthe first two ballots are byte-identical, but their comments claim one is "via the roles assignment" and the other "the structured form of the same thing".
This merge request was prepared with the assistance of an AI agent (Claude). The changes and the wording were reviewed by me before pushing, and accountability for the content is mine.