Skip to content
Snippets Groups Projects

Automated Project Update Bot fixes

Merged project update bot requested to merge issue/ng_lightbox-3433565:project-update-bot-only into 2.x
5 unresolved threads

This merge request was automatically created by the Project Update Bot. It contains the changes from run 11-127659.

Merge request reports

Approval is optional
Code Quality is loading
Test summary results are being parsed

Merged by Adam BramleyAdam Bramley 1 month ago (Jan 14, 2025 11:37pm UTC)

Merge details

  • Changes merged into 2.x with 659f38a0 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 2248e1ce - Update file ng_lightbox.info.yml

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • 24 24 /**
    25 25 * {@inheritdoc}
    26 26 */
    27 protected static $modules = [
    28 'ng_lightbox',
    29 'views',
    30 'node',
    31 'filter',
    32 'path_alias',
    33 'path',
    27 protected static $modules = ['ng_lightbox', 'views',
  • 20 20 *
    21 21 * @var array
    22 22 */
    23 protected static $modules = [
    24 'system',
    25 'node',
    26 'user',
    27 'path_alias',
    28 'ng_lightbox',
    29 'path',
    23 protected static $modules = ['system', 'node', 'user',
  • 66 74 * The config factory so we can get the lightbox settings.
    67 75 * @param \Drupal\Core\Routing\AdminContext $admin_context
    68 76 * Provides a helper class to determine whether the route is an admin one.
    77 * @param \Symfony\Component\HttpFoundation\RequestStack $request_stack
    78 * The request stack.
    69 79 */
    70 public function __construct(PathMatcherInterface $path_matcher, AliasManagerInterface $alias_manager, ConfigFactoryInterface $config_factory, AdminContext $admin_context) {
    80 public function __construct(
    81 PathMatcherInterface $path_matcher,
    82 AliasManagerInterface $alias_manager,
    83 ConfigFactoryInterface $config_factory,
    84 AdminContext $admin_context,
    85 RequestStack $request_stack,
  • Thanks, please check my feedback.

  • added 1 commit

    Compare with previous version

  • 71 71 $config_factory->get(Argument::exact('ng_lightbox.settings'))->willReturn($config);
    72 72 $admin_context = $this->prophesize('Drupal\Core\Routing\AdminContext');
    73 73 $admin_context->isAdminRoute()->willReturn($is_admin_route);
    74 $requestStack = $this->prophesize('Symfony\Component\HttpFoundation\RequestStack');
  • 1 1 name: NG Lightbox
    2 2 description: A path based lightbox solution using CSS 3 properties.
    3 3 type: module
    4 core_version_requirement: ^8 || ^9 || ^10
    4 core_version_requirement: ^9.5 || ^10 || ^11
  • Adam Bramley added 1 commit

    added 1 commit

    Compare with previous version

  • Adam Bramley added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading