Skip to content
Snippets Groups Projects

Replace typography with Figma Styles

Closes #3435981

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
106 --admin-toolbar-line-height-level-2: var(--drupal-admin-line-height-level-2, 1.333);
107 --admin-toolbar-font-size-level-3: var(--drupal-admin-font-size-level-3, calc(0.75 * var(--admin-toolbar-rem))); /* 12px */
108 --admin-toolbar-line-height-level-3: var(--drupal-admin-line-height-level-3, 1.333);
109 --admin-toolbar-font-size-popover-header: var(--drupal-admin-font-size-popover-header, calc(0.875 * var(--admin-toolbar-rem))); /* 14px */
110 --admin-toolbar-line-height-popover-header: var(--drupal-admin-line-height-popover-header, 1.14286);
111 --admin-toolbar-font-size-menu-block-label: var(--drupal-admin-font-size-menu-block-label, calc(0.625 * var(--admin-toolbar-rem))); /* 10px */
112 --admin-toolbar-line-height-menu-block-label: var(--drupal-admin-line-height-menu-block-label, 1.6);
113 /* TODO: We don't have yet design for dropdown links in Top Bar. */
114 /* The provided values are not final */
115 --admin-toolbar-font-size-toolbar-dropdown-link: var(--drupal-admin-font-size-toolbar-dropdown-link, var(--admin-toolbar-rem)); /* 16px */
116 --admin-toolbar-line-height-toolbar-dropdown-link: var(--drupal-admin-line-height-toolbar-dropdown-link, 1.333);
117
118 /**
119 * Font weights.
120 */
121 --admin-toolbar-font-weight-400: var(--drupal-admin-font-weight-600, 400);
  • IMHO this is an overkill. If you want to set 600 as the font weight, you just add 500 instead of --admin-toolbar-font-weight-600. If you want to redefine all the "bold" styles, we should define something along the line "--admin-toolbar-font-bold" and define it to 600. But the whole reason behind using a variable font is having more flexibility, and user could decide to keep some bold to 600, and change some other to 700 and we can't predict that. We're already adding maintainability burden with the font sizes, I would add this too.

  • Konstantin Shupenko changed this line in version 3 of the diff

    changed this line in version 3 of the diff

  • Please register or sign in to reply
  • added 1 commit

    • 3b5aa30b - Replace typography with Figma Styles

    Compare with previous version

  • added 6 commits

    Compare with previous version

  • Konstantin Shupenko resolved all threads

    resolved all threads

  • 48 48 {% if item.below is empty %}
    49 49 <a
    50 50 href="{{ item.url }}"
    51 class="toolbar-button"
    51 class="toolbar-button toolbar-button--level-1"
    52 52 >{{ item.title }}</a>
    53 53 {% else %}
    54 54 <button
    55 class="toolbar-button toolbar-button--expand--down"
    55 class="toolbar-button toolbar-button--level-1 toolbar-button--expand--down"
  • added 1 commit

    • 6c57e8dd - Added design system variables

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • added 3 commits

    • 3a0eb905 - 1 commit from branch project:1.x
    • c342bbbe - Replace typography with Figma Styles
    • f493fbf3 - Added design system variables

    Compare with previous version

  • added 1 commit

    • fd06dcfa - Removed toolbar-button--level-1 modifier

    Compare with previous version

  • Cristina Chumillas started a merge train

    started a merge train

  • Please register or sign in to reply
    Loading