Closes #3426576 Add tests for user navigation block

Closes #3426576

added 2 commits

• 06485607 - Issue #3426576: Minor updates to test naming
• b462ed95 - Issue #3426576: Fix test to be more robust

Compare with previous version

added 1 commit

• 04f5a9c3 - Issue #3426576: Adjust test assertion to please phpstan

Compare with previous version

Code looks good and tests covers the logic.

I believe we might have a better coverage if we ensure the cache HIT/MISS dance is happening as expected, not only the UI result. Same UI output could be wrong if user block is not being cached as expected.

I would recommend to follow a similar approach to ShortcutCacheTagsTest::testToolbar.

That one could also be added on top of the ones you already created that look great.

added 2 commits

• bf46f479 - Issue #3426576: Address code review
• 24ff9372 - Issue #3426576: Add assertions for checking page and dynamic page cache...

Compare with previous version

resolved all threads

added 1 commit

• e321d529 - Issue #3426576: Fix caching bug rendering dynamic page cache uncacheable

Compare with previous version

resolved all threads

added 5 commits

• 24ff9372...cc02ac59 - 4 commits from branch project:1.x
• bf4e8c7e - Merge branch '1.x' into 3426576-add-tests-for

Compare with previous version

started a merge train

merged