Skip to content
Snippets Groups Projects

Resolve #3402592 "Reset css"

Merged Ivan Berdinsky requested to merge issue/navigation-3402592:3402592-reset-css into 1.x

Closes #3402592

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I've left a few inline comments.

    About the px solution proposed, I don't have a strong opinion. I tested it locally and it seems to work fine, but I would love to hear from an accessibility expert to sign-off on the change.

    Thanks Ivan for all the work here!

  • Ben Mullins added 3 commits

    added 3 commits

    Compare with previous version

  • reopened

  • Mithun S added 1 commit

    added 1 commit

    • cca0e4cc - Issue-3402592: Rename the files form admin-inital-styles to admin-reset-styles.

    Compare with previous version

  • Aubrey Sambor added 4 commits

    added 4 commits

    Compare with previous version

  • Aubrey Sambor added 2 commits

    added 2 commits

    • 75ff4ddb - 3402592: Clean up selector specificity
    • 5c0bc460 - 3402592: Update selector specificity

    Compare with previous version

  • Ivan Berdinsky
  • Aubrey Sambor added 1 commit

    added 1 commit

    • 81c83cfd - 3402592: Update selector to be less specific

    Compare with previous version

  • reopened

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading