Skip to content
Snippets Groups Projects

Reset theme css - #3402592

Open Reset theme css - #3402592
issue/navigation-3402592:3402592-reset-theme-css into 1.x
3 unresolved threads
Open Ivan Berdinsky requested to merge issue/navigation-3402592:3402592-reset-theme-css into 1.x
3 unresolved threads

Closes #3402592

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
css/components/admin-toolbar.css
85 85 transform: translateX(-100%);
86 86 border-inline-end: 1px solid var(--admin-toolbar-color-gray-100);
87 87 background-color: var(--admin-toolbar-color-white);
88 font-family: BlinkMacSystemFont, -apple-system, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
  • Mike Herchel
    Mike Herchel @mherchel started a thread on the diff
    • scripts/css/compile.js
    45 '!border-top*',
    46 '!border-right*',
    47 '!border-bottom*',
    48 '!border-left*',
    49 '!border-start*',
    50 '!border-end*',
    51 '!outline*',
    52 ],
    53 mediaQuery: true,
    54 minPixelValue: 3,
    55 // Prevent converting PX to REM for icon styles. These files have been
    56 // added to use the `postcssUrl` plugin, but aren't compatible with
    57 // `postcssPixelsToRem`.
    58 exclude: (filePath) => filePath.match(/core\/modules.*\.icons\..*\.pcss\.css$/)
    59
    60 }),
    • Mike Herchel
      Mike Herchel @mherchel
      Maintainer

      We shouldn't be removing this. @ckrina told me the reason was that the bootstrap theme sets the root font size to 14px. I understand that's an issue, but styling font sizes using pixel units can be problematic for some assistive technology as it can prevent text from resizing if the user requests it to do. Pixel units will not get past the core accessibility gate.

    • Ivan Berdinsky
      Ivan Berdinsky @finnsky
      Author Developer

      sorry but bootstrap in basic setup is 10 px.

      child menu items became unreadable in size of 7.5px

    • Please register or sign in to reply
  • Mike Herchel
    Mike Herchel @mherchel started a thread on the diff
    • css/components/admin-initial-styles.pcss.css 0 → 100644
    1 /**
    2 * @file
    3 * Reset styles from parent theme.
    4 * https://developer.mozilla.org/en-US/docs/Web/CSS/all
    5 */
    6
    7 :where([data-admin-ui-initial-styles]) {
    8 all: initial;
    Please register or sign in to reply