Skip to content
Snippets Groups Projects

#3258777: Various fixes

8 files
+ 84
50
Compare changes
  • Side-by-side
  • Inline
Files
8
@@ -4,8 +4,8 @@ namespace Drupal\migrate_visualize\Controller;
@@ -4,8 +4,8 @@ namespace Drupal\migrate_visualize\Controller;
use Drupal\Core\Controller\ControllerBase;
use Drupal\Core\Controller\ControllerBase;
use Drupal\migrate\Plugin\MigrationPluginManagerInterface;
use Drupal\migrate\Plugin\MigrationPluginManagerInterface;
 
use Drupal\migrate_plus\Entity\Migration;
use Drupal\migrate_visualize\MigrateGraph;
use Drupal\migrate_visualize\MigrateGraph;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
/**
/**
@@ -52,25 +52,15 @@ class VisualizeController extends ControllerBase {
@@ -52,25 +52,15 @@ class VisualizeController extends ControllerBase {
/**
/**
* Visualize the migration.
* Visualize the migration.
*
* @todo Can the parameter be upcast?
* @see https://www.drupal.org/docs/8/api/routing-system/parameters-in-routes/how-upcasting-parameters-works
*/
*/
public function build(string $migration) {
public function build(Migration $migration) {
 
$migrationPlugin = $this->migrationPluginManager->createInstance($migration->id(), $migration->toArray());
 
$build['switcher'] = $this->formBuilder()
$build['switcher'] = $this->formBuilder()
->getForm('Drupal\migrate_visualize\Form\VisualizeMigrationSwitcherForm');
->getForm('Drupal\migrate_visualize\Form\VisualizeMigrationSwitcherForm');
$migrationInstance = $this->migrationPluginManager->createInstance($migration);
if ($migration !== '' && $migrationInstance === FALSE) {
$this->messenger()
->addError($this->t('Migration not found: @migration', [
'@migration' => $migration,
]));
throw new NotFoundHttpException();
}
try {
try {
$this->migrationGraph->graph($migrationInstance);
$this->migrationGraph->graph($migrationPlugin);
}
}
catch (\Exception $exception) {
catch (\Exception $exception) {
$this->messenger()
$this->messenger()
@@ -83,7 +73,7 @@ class VisualizeController extends ControllerBase {
@@ -83,7 +73,7 @@ class VisualizeController extends ControllerBase {
}
}
$build['visualize'] = [
$build['visualize'] = [
'#migration' => $migrationInstance,
'#migration' => $migrationPlugin,
'#weight' => 110,
'#weight' => 110,
];
];
Loading