Skip to content
Snippets Groups Projects

Issue #3217657: Allow developers to expose more configuration in the migrate form

Merged Issue #3217657: Allow developers to expose more configuration in the migrate form
1 unresolved thread
1 unresolved thread

Closes #3217657

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 173 173 $this->messenger()->addWarning($this->t('Migration @id reset to Idle', ['@id' => $migration_id]));
    174 174 }
    175 175
    176 $executable = new MigrateBatchExecutable($migration, new StubMigrationMessage(), $this->getBatchOptions($form, $form_state));
    177 $executable->batchImport();
    178 }
    179
    180 /**
    181 * Prepares an array of migrate batch options.
    182 */
    183 protected function getBatchOptions($form, FormStateInterface $form_state) {
    • Suggested change
      183 protected function getBatchOptions($form, FormStateInterface $form_state) {
      183 protected function getMigrationOptions($form, FormStateInterface $form_state) {

      Naming things is hard. Maybe this is a better name?

    • I've merged the MR into migrate tools. Should this do some version checking or anything to make sure this module uses the right version of migrate tools? Otherwise, this will stop working if someone doesn't upgrade to a newer version of tools.

    • Thanks. I'll have to review this again to refresh my memory and then come back with some proposal.

    • Lucas Hedding changed this line in version 1 of the diff

      changed this line in version 1 of the diff

    • Please register or sign in to reply
  • Lucas Hedding added 8 commits

    added 8 commits

    Compare with previous version

  • added 1 commit

    • 4c6b4183 - Issue #3217657 by welly, Matroskeen, heddn: Allow developers to expose more...

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Lucas Hedding started a merge train

    started a merge train

  • Lucas Hedding removed this merge request from the merge train

    removed this merge request from the merge train

  • Please register or sign in to reply
    Loading