Issue #2822737 by Matroskeen, mpriscella, cruno: Configuration is not cleaned...

Issue #2822737 by Matroskeen, mpriscella, cruno: Configuration is not cleaned on uninstall process of example modules (Migrate Example, Migrate Example (Advanced), Migrate JSON Example)

migrate_example/migrate_example_setup/config/install/comment.type.node_comments.yml

 langcode: en
 status: true
-dependencies: {  }
+dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
 id: node_comments
 label: 'Node comments'
 target_entity_type_id: node

migrate_example/migrate_example_setup/config/install/field.storage.node.field_comments.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
   module:
     - comment
     - node

migrate_example/migrate_example_setup/config/install/field.storage.node.field_migrate_example_beer_style.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
   module:
     - node
     - taxonomy

migrate_example/migrate_example_setup/config/install/field.storage.node.field_migrate_example_country.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
   module:
     - node
 id: node.field_migrate_example_country

migrate_example/migrate_example_setup/config/install/field.storage.node.field_migrate_example_image.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
   module:
     - file
     - image

migrate_example/migrate_example_setup/config/install/field.storage.user.field_migrate_example_favbeers.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
   module:
     - node
     - user

migrate_example/migrate_example_setup/config/install/field.storage.user.field_migrate_example_gender.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
   module:
     - user
 id: user.field_migrate_example_gender

migrate_example/migrate_example_setup/config/install/node.type.migrate_example_beer.yml

 langcode: en
 status: true
+dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
 name: Beer
 type: migrate_example_beer
 description: 'Beer is what we drink.'

migrate_example/migrate_example_setup/config/install/taxonomy.vocabulary.migrate_example_beer_styles.yml

 langcode: en
 status: true
-dependencies: {  }
+dependencies:
+  enforced:
+    module:
+      - migrate_example_setup
 name: 'Migrate Example Beer Styles'
 vid: migrate_example_beer_styles
 description: 'Use tags to group beers on similar topics into categories.'

migrate_example/tests/src/Kernel/MigrateExampleTest.php

@@ -4,6 +4,7 @@ declare(strict_types = 1);
 
 namespace Drupal\Tests\migrate_example\Kernel;
 
+use Drupal\node\Entity\NodeType;
 use Drupal\Tests\migrate_drupal\Kernel\MigrateDrupalTestBase;
 
 /**
@@ -40,6 +41,7 @@ final class MigrateExampleTest extends MigrateDrupalTestBase {
     $this->installSchema('system', ['sequences']);
     $this->installSchema('comment', ['comment_entity_statistics']);
     $this->installSchema('node', ['node_access']);
+    $this->installSchema('user', ['users_data']);
 
     // Install the module via installer to trigger hook_install.
     \Drupal::service('module_installer')->install(['migrate_example_setup']);
@@ -71,4 +73,20 @@ final class MigrateExampleTest extends MigrateDrupalTestBase {
     $this->assertCount(5, $comments);
   }
 
+  /**
+   * Tests whether the module can be uninstalled and installed again.
+   *
+   * Also, checks whether the example configs are removed after uninstall.
+   */
+  public function testModuleCleanup(): void {
+    $test_node_type = 'migrate_example_beer';
+    // Prove that test content type existed before the uninstall process.
+    $this->assertInstanceOf(NodeType::class, NodeType::load($test_node_type));
+    \Drupal::service('module_installer')->uninstall(['migrate_example_setup']);
+    // Make sure the test content type was removed.
+    $this->assertNull(NodeType::load($test_node_type));
+    // Check whether the module can be installed again.
+    \Drupal::service('module_installer')->install(['migrate_example_setup']);
+  }
+
 }

migrate_example_advanced/migrate_example_advanced_setup/config/install/comment.type.migrate_example_advanced_comment.yml

 langcode: en
 status: true
-dependencies: {  }
+dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
 id: migrate_example_advanced_comment
 label: 'Node comments'
 target_entity_type_id: node

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_adv_image.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - file
     - image

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_comments.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - comment
     - node

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_top_vintag.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - node
 id: node.field_migrate_example_top_vintag

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_wine_best.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - node
     - taxonomy

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_wine_ratin.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - node
 id: node.field_migrate_example_wine_ratin

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_wine_regio.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - node
     - taxonomy

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.node.field_migrate_example_wine_var.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - node
     - taxonomy

migrate_example_advanced/migrate_example_advanced_setup/config/install/field.storage.taxonomy_term.field_variety_attributes.yml

 langcode: en
 status: true
 dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
   module:
     - taxonomy
 id: taxonomy_term.field_variety_attributes

migrate_example_advanced/migrate_example_advanced_setup/config/install/node.type.migrate_example_producer.yml

 langcode: en
 status: true
-dependencies: {  }
+dependencies:
+  enforced:
+    module:
+      - migrate_example_advanced_setup
 name: 'Wine Producer'
 type: migrate_example_producer
 description: 'Wineries, vineyards, and large producers.'