Skip to content
Snippets Groups Projects

Issue #1372176: Custom text for 'Home' link.

Open Issue #1372176: Custom text for 'Home' link.
issue/menu_breadcrumb-1372176:1372176-custom-text-for into 2.0.x
1 unresolved thread
Open Manish Sharma requested to merge issue/menu_breadcrumb-1372176:1372176-custom-text-for into 2.0.x
1 unresolved thread

Closes #1372176

Merge request reports

Members who can merge are allowed to add commits.

Merged results pipeline #393829 passed

Stage: build
Stage: validate
Stage: test

Merged results pipeline passed for 7cf2ef2b

Approval is optional
Code Quality is loading
Test summary results are being parsed
Full report
Ready to merge by members who can write to the target branch.
  • 1 commit will be added to 2.0.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Burgess
    Chris Burgess @xurizaemon started a thread on the diff
    • tests/src/Functional/SettingsFormTest.php
    154 157 $page->checkField('exclude_disabled_menu_items');
    155 158 $page->checkField('derived_active_trail');
    156 159 $page->selectFieldOption('front_title', 1);
    160 $page->fillField('custom_home_title', 'Home Page');
    • Chris Burgess
      Chris Burgess @xurizaemon
      Maintainer

      I haven't tested this, but I think from the settings form above, this field should only be visible when front_title is set to 3, and here it will be set to 1. This same issue appears a couple of times below also.

      (The integers should be replaced with meaningful constant names, but that's out of scope here.)

    • Manish Sharma
      Manish Sharma @manish-31
      Author

      @xurizaemon Since, we don't have any restriction to save the value of custom_home_title field I think we should be good here and in this test we are just checking if the config values are stored properly on form submit.

    • Please register or sign in to reply
  • Chris Burgess
    Chris Burgess @xurizaemon
    Maintainer

    This looks promising thanks! I have only visually reviewed in Gitlab, not tested locally. Couple of minor changes requested in review notes.

  • Manish Sharma added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Burgess added 9 commits

    added 9 commits

    Compare with previous version

  • Chris Burgess added 3 commits

    added 3 commits

    Compare with previous version

    • Please register or sign in to reply