Skip to content
Snippets Groups Projects

created mr for markdown-easy

Open created mr for markdown-easy
issue/markdown_easy-3496182:3496182-markdown-easy into 1.0.x
3 unresolved threads
Open Deepali Sardana requested to merge issue/markdown_easy-3496182:3496182-markdown-easy into 1.0.x
3 unresolved threads

Closes #3496182

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #379611 passed with warnings

Stage: build
Stage: validate
Stage: test

Merge request pipeline passed with warnings for 09d24ba8

Approval is optional
Code Quality is loading
Test summary results are being parsed
Full report
Ready to merge by members who can write to the target branch.
  • 1 commit will be added to 1.0.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
composer.json
3 3 "description": "A simple Markdown text filter for Drupal.",
4 4 "type": "drupal-module",
5 5 "require": {
6 "league/commonmark": "^2.4"
6 "league/commonmark": "^2.4",
7 "drupal/markdown_easy_entities": "1.0.x-dev"
  • Bram Driesen
    Bram Driesen @BramDriesen started a thread on the diff
    • markdown_easy.install
    37 'value' => t('Text format configured insecurely.'),
    38 'description' => t('The text format %format is potentially configured insecurely. The "Limit allowed HTML tags and correct faulty HTML" filter is strongly recommended and should be configured to run after the Markdown Easy filter.', ['%format' => $format->get('name')]),
    39 'severity' => REQUIREMENT_WARNING,
    40 ];
    41 }
    42 if (!isset($weights['filter_autop']) || ($weights['filter_autop'] < $weights['markdown_easy'])) {
    43 $requirements['markdown_easy_filter_configuration_filter_autop'] = [
    44 'title' => t('Markdown Easy'),
    45 'value' => t('Text format configured insecurely.'),
    46 'description' => t('The text format %format is potentially configured incorrectly. The "Convert line breaks into HTML" filter is recommended and should be configured to run after the Markdown Easy filter.', ['%format' => $format->get('name')]),
    47 'severity' => REQUIREMENT_WARNING,
    48 ];
    49 }
    50 }
    20 $filter_config_array = get_filter_configurations($format);
    21 $warnings = check_markdown_easy_configuration($format, $filter_config_array);
  • Bram Driesen
    Bram Driesen @BramDriesen started a thread on the diff
    • markdown_easy.install
    28
    29 /** @var Drupal\markdown_easy\MarkdownUtility */
    30 $markdown_easy_utility_service = \Drupal::service('markdown_easy.utility');
    31 $weights = $markdown_easy_utility_service->getFilterWeights($filter_config_array);
    32
    33 if (isset($weights['markdown_easy'])) {
    34 if (!isset($weights['filter_html']) || ($weights['filter_html'] < $weights['markdown_easy'])) {
    35 $requirements['markdown_easy_filter_configuration_limit_html'] = [
    36 'title' => t('Markdown Easy'),
    37 'value' => t('Text format configured insecurely.'),
    38 'description' => t('The text format %format is potentially configured insecurely. The "Limit allowed HTML tags and correct faulty HTML" filter is strongly recommended and should be configured to run after the Markdown Easy filter.', ['%format' => $format->get('name')]),
    39 'severity' => REQUIREMENT_WARNING,
    40 ];
    41 }
    42 if (!isset($weights['filter_autop']) || ($weights['filter_autop'] < $weights['markdown_easy'])) {
    43 $requirements['markdown_easy_filter_configuration_filter_autop'] = [
    Please register or sign in to reply