Skip to content
Snippets Groups Projects

Issue #3359046: fix phpcs warnings

Merged Volha requested to merge issue/map_object_field-3359046:3359046-phpsec-issue-2 into 8.x-1.x
2 unresolved threads

Closes #3359046

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
25 25 public function viewElements(FieldItemListInterface $items, $langcode) {
26 26 $elements = [];
27 27 /** @var \Drupal\map_object_field\MapObject\MapObjectService $map_object_service */
28 $map_object_service = \Drupal::service('map_object.service');
28 $map_object_service = $this->service('map_object.service');
  • 49 49 '#mapHeight' => $this->getSetting('map_height'),
    50 50 ];
    51 51 /** @var \Drupal\map_object_field\Service\MapObjectLibInterface $map_bject_field_lib */
    52 $map_bject_field_lib = \Drupal::service('map_object_field_lib');
    52 $map_bject_field_lib = $this->service('map_object_field_lib');
  • The changes that should remove calls to \Drupal::service() are not correct, for the same reason I gave in the comments for my review.

    The MR is also not complete, since it should fix all the shown errors/warnings, not just what the other MR does not fix.

  • Please register or sign in to reply
    Loading