Skip to content
Snippets Groups Projects
eduardo morales alberti's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

Added comments on each service definition....

eduardo morales alberti's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

Done

eduardo morales alberti's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

Done

eduardo morales alberti's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

Sorry, could you explain more about what needs to be changed?

eduardo morales alberti's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

Done!

eduardo morales alberti's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

Done

Omar Mohamad - El Hassan Lopesino's avatar
commented on merge request !18 "Issue #3520805: New hook to alter log entity operation diffs" at project / log_entity_operations

It is needed to check that $diff_array is defined, which is only defined at some specific use cases....

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

what exactly are we doing here? please add some comments

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

ignore, I see it in info file

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

another module / custom module?

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

let's also add file_path so we know if it is file_path empty or file doesn't exist

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

new line before comments to keep it readable

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

add a little more, like failed to read file

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

also let's avoid variable assignment in if condition

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

unwanted empty line

Nikunj Kotecha's avatar
commented on merge request !17 "Issue #3520644 by eduardo morales alberti: Add the hability to recover removed..." at project / log_entity_operations

we should have dependency of the entity module, for logs there is no way to restore / backup

Omar Mohamad - El Hassan Lopesino's avatar
commented on merge request !18 "Issue #3520805: New hook to alter log entity operation diffs" at project / log_entity_operations

I forgot to commit these lines that I've changed. Now it is fixed.

Nikunj Kotecha's avatar
commented on merge request !18 "Issue #3520805: New hook to alter log entity operation diffs" at project / log_entity_operations

should this be outside if condition ?

Nikunj Kotecha's avatar
commented on merge request !18 "Issue #3520805: New hook to alter log entity operation diffs" at project / log_entity_operations

where is $diff_json defined?

Omar Mohamad - El Hassan Lopesino's avatar
opened merge request !18 "Issue #3520805: New hook to alter log entity operation diffs" at project / log_entity_operations