Skip to content
Snippets Groups Projects

Support more flexible LMS-LRS identifiers

Merged Marcin Grabias requested to merge issue/lms_xapi-3494503:3494503-allow-more-flexible into 1.0.x
1 unresolved thread

Closes #3494503

Merge request reports

Approval is optional
Code Quality is loading
Test summary results are being parsed

Merged by Marcin GrabiasMarcin Grabias 5 months ago (Dec 19, 2024 9:55am UTC)

Merge details

  • Changes merged into 1.0.x with 70be2fb9 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
15 */
16 class LmsXapiLessonSubscriber implements EventSubscriberInterface {
17
18 /**
19 * Constructor.
20 */
21 public function __construct(
22 private readonly RequestStack $requestStack,
23 private readonly TrainingManager $trainingManager,
24 private readonly AccountInterface $currentUser,
25 ) {}
26
27 /**
28 * {@inheritdoc}
29 */
30 public static function getSubscribedEvents(): array {
  • Tagged services with an applies() method, similar to breadcrumb builders, might be easier to follow here than an event. e.g. the logic checking about whether we care or not can go in the applies() method and then the ID generation method would only be called if we do.

  • Feel free to create a follow-up and post a MR once this lands.

  • Please register or sign in to reply
  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading