Issue #3492930: add xapi ActivityAnswer plugin.
1 unresolved thread
Closes #3492930
Merge request reports
Activity
- This was supposed to be a sub-module providing that plugin as it requires Drupal LMS, contradictory to parent LMS Xapi.
- Missing installation field config. See https://git.drupalcode.org/project/lms/-/tree/1.0.x/modules/lms_answer_plugins?ref_type=heads for an example.
- I just fixed composer.json so let's merge 1.0.x here and phpstan should have needed dependencies.
#1. An optional plugin should be fine, it would only be picked up with the LMS module is installed, but also happy moving it to a sub-module, will do that.
#2. I don't think we should add field config for this yet, would prefer if we removed all the existing shipped config from Drupal LMS into a separate lms_recipe project. Will open a new issue to discuss in the main project.
Opened https://www.drupal.org/project/lms/issues/3493239 for #2.
added 2 commits
added 2 commits
added 11 commits
-
9c5387af...1d3ce50d - 4 commits from branch
project:1.0.x - f36a057e - Issue #3492930: add xapi ActivityAnswer plugin.
- f62d26f6 - Move the plugin to a submodule.
- ca3b3589 - Change module description.
- 8c30ca18 - Add stub config exports.
- f5b616bb - Make evaluatedOnSave work.
- 712258fc - Use the activity ID.
- 1d58edd1 - Add a XapiIdGenerator.
Toggle commit list-
9c5387af...1d3ce50d - 4 commits from branch
added 2 commits
54 54 return parent::buildForm($form, $form_state); 55 55 } 56 56 57 /** 58 * {@inheritdoc} 59 */ 60 public function validateForm(array &$form, FormStateInterface $form_state) { -
Since we're removing this, created https://www.drupal.org/project/lms_xapi/issues/3499403.
added 1 commit
- 7afcec27 - Update for new plugin base class constructor param.
Please register or sign in to reply