Skip to content
Snippets Groups Projects
Marcin Grabias's avatar
joined project project / lms_h5p
catch's avatar
pushed new tag 1.0.0-alpha3 at project / lms_h5p
catch's avatar
pushed to branch 1.0.x at project / lms_h5p
catch's avatar
accepted merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p
catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

It's needed because we don't want to query the LRS every time we want the score, if the score is requested multiple times on a page.

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Had to refactor things a bit, but think the new version handles it.

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Rise to alpha3 after resolving !1 (diffs, comment 516607)

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Review and release https://www.drupal.org/project/lms_xapi/issues/3524661, get rid of the duplicated code here in favor of getLatestStatementByUuid()

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Ahh, we probably need to $clicked_button->click() instead.

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

This clicks the back button unfortunately. I don't know why though so needs a bit js debugging.

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Remove comment.

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Needs resolving.

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

I think it's nice. I'd just sleep for half a second after clicking the check answer button. Also, we need to check if the check answer button exist...

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Actually it works even though $variables isn't a render array, we we can replace several lines of a code with an explanatory comment. A small hack ...

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Added some js to click the 'check' button when the 'next' button is clicked.

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

This is the H5P formatter, it's mostly because of the iframe implementation, because render blocking assets are chained from within the iframe. Nee...

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Oh I see......

Marcin Grabias's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Yes, I added it in this branch.

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Yes because this one is a render array ;)

catch's avatar
commented on merge request !1 "#3524373: Initial review comments & updates." at project / lms_h5p

Would be great but $variables isn't a render array.