Draft: Module review

Closes #3502628

modules/lms_certificate_fillpdf/src/Controller/CertificateController.php

 <?php
 
+// This should probably reside in the parent module. 
+
 declare(strict_types=1);
 
 namespace Drupal\lms_certificate_fillpdf\Controller;

[catch]

This isn't possible because it would introduce a dependency on drupal/fillpdf - which the parent module can't have.

We can open a follow-up issue to convert this controller logic into a plugin, and then move the controller to the parent module and look for a plugin etc. but that's part of generically supporting multiple different certificate types on one site which isn't necessary for the absolute minimum.

[Marcin Grabias]

We could use a plugin system and generate that link from a plugin but ok, I agree that can be done later when we'll have at least one more certificate type.