Skip to content
Snippets Groups Projects
abelass's avatar
opened merge request !23 "#3457016 - Fix Circular Ref Issue" at project / lightning_workflow
Adam Balsam's avatar
pushed new branch 5.0.x at project / lightning_workflow
Vishal Khode's avatar
Vipin Mittal's avatar
Katherine Druckman's avatar
abelass's avatar
opened merge request !22 "Remove submodule lightning scheduler, use standalone module instead" at project / lightning_workflow
Chandan Singh's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

We can't make non static method call here, also RandomGeneratorTrait uses the same method of Random class.

Chandan Singh's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

That should be more of a maintenance call.

Chandan Singh's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

I think its required, please check the failing test here

Chandan Singh's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

That should be more of a maintenance call.

Chandan Singh's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

We are setting request time with initialise value which can be a valid timestamp.

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

This can be replaced with Drupal\Component\Utility\Random::string()

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

minimum support ^9.5

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

Remove this commented line 49-50

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

Changes not include any multi-line comma separator in the constructor or any function then I guess this variable also needs to be removed.

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

No need of this variable.

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

This should be "drupal/moderation_dashboard": "^2 || ^3",

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

This would work "drupal/inline_entity_form": "^3", (As it supports D8-11

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

Can we add minimum support ^9.5 if planning to keep support of D9

Ankit Pathak's avatar
commented on merge request !20 "D11 compatibility." at project / lightning_workflow

Typehint array missing