Skip to content
Snippets Groups Projects

Update composer.json

Open Update composer.json
issue/lightning_core-3112055:3112055-update-patch-that into 8.x-5.x
1 unresolved thread
Open Lawxen Liu requested to merge issue/lightning_core-3112055:3112055-update-patch-that into 8.x-5.x
1 unresolved thread

Related to #3112055

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
composer.json
28 28 },
29 29 "patches": {
30 30 "drupal/core": {
31 "2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch"
31 "2869592 - Disabled update module shouldn't produce a status report warning": "https://git.drupalcode.org/project/drupal/-/merge_requests/1517.diff"
  • Heikki Ylipaavalniemi
    Heikki Ylipaavalniemi @HeikkiY

    This seems to take the direct MR diff as the change instead of a static file. This is generally a bad practise as noted in https://docs.cweagans.net/composer-patches/usage/defining-patches: The contents of these patches can change by pushing more commits to a pull request or merge request. A malicious user could abuse this behavior to cause you to deploy code that you didn’t mean to deploy. If you must use a PR/MR as the basis for a patch, download the patch, include it in your project, and apply the patch using the local path instead.

  • Please register or sign in to reply
Please register or sign in to reply