Skip to content
Snippets Groups Projects

Issue #3302242: Required parameter $flatten follows optional parameter $type in ldap_servers/ldap_servers.module

Open Issue #3302242: Required parameter $flatten follows optional parameter $type in ldap_servers/ldap_servers.module
issue/ldap-3302242:3302242-php-8-compatibility into 7.x-2.x
5 unresolved threads
Open solideogloria requested to merge issue/ldap-3302242:3302242-php-8-compatibility into 7.x-2.x
5 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
ldap_query/ldap_query.module
128 128 * of server conf object keyed on sid
129 129 * - single server conf object (if flatten == TRUE)
130 130 */
131 function ldap_query_get_queries($qid = NULL, $type, $flatten = FALSE, $reset = FALSE) {
131 function ldap_query_get_queries($qid, $type = 'all', $flatten = FALSE, $reset = FALSE) {
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • ldap_servers/LdapServer.class.php
    792 792 * elements if search returns no results),
    793 793 * or FALSE on error.
    794 794 */
    795 public function search($base_dn = NULL,
    796 $filter,
    797 $attributes = [],
    795 public function search(
    796 $base_dn = NULL,
    797 $filter = '',
    798 $attributes = [],
    • Comment on lines +796 to +798
      Alberto Paderno
      Alberto Paderno @avpaderno

      There is no need to make all the parameters optional. It is sufficient to make the first one mandatory, which is exactly how PHP handles the first parameter, since it is followed by another mandatory parameter.

    • Please register or sign in to reply
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • ldap_servers/LdapServer.class.php
    957 969 else {
    958 970 $skipped_page = TRUE;
    959 971 }
    960 @ldap_control_paged_result_response($this->connection, $result, $page_token, $estimated_entries);
    972 ldap_parse_result($this->connection, $result, $errcode, $matcheddn, $errmsg, $referrals, $controls);
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • ldap_servers/ldap_servers.module
    581 581 /**
    582 582 * See ldap_servers_get_servers()
    583 583 */
    584 function _ldap_servers_get_simpletest_servers($sid, $type = NULL, $flatten, $reset = TRUE) {
    584 function _ldap_servers_get_simpletest_servers($sid, $type, $flatten, $reset) {
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • ldap_servers/ldap_servers.module
    581 581 /**
    582 582 * See ldap_servers_get_servers()
    583 583 */
    584 function _ldap_servers_get_simpletest_servers($sid, $type = NULL, $flatten, $reset = TRUE) {
    584 function _ldap_servers_get_simpletest_servers($sid, $type, $flatten, $reset) {
    585 585
    586 586 if (!$type) {
    587 587 $type = 'all';
    Please register or sign in to reply