Issue #3432543: Renaming of acctCreation ldap_behaviour to ldap_behavior breaks existing installs

ldap_user/ldap_user.install

@@ -329,3 +329,15 @@ function ldap_user_update_8407() {
   $settings->set('userUpdateOnly', FALSE);
   $settings->save();
 }
+
+/**
+ * Fix account creation setting spelling.
+ */
+function ldap_user_update_8408() {
+  $settings = \Drupal::configFactory()->getEditable('ldap_user.settings');
+  /* cSpell:ignore behaviour */
+  if ($settings->get('acctCreation') === 'ldap_behaviour') {
+    $settings->set('acctCreation', 'ldap_behavior');
+    $settings->save();
+  }
+}

ldap_user/tests/src/Unit/InstallTest.php

+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\Tests\ldap_user\Unit;
+
+use Drupal\Tests\UnitTestCase;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+require_once __DIR__ . '/../../../ldap_user.install';
+
+/**
+ * Test the install functions.
+ *
+ * @package Drupal\Tests\ldap_user\Unit
+ */
+class InstallTest extends UnitTestCase {
+
+  /**
+   * The container interface.
+   *
+   * @var \Symfony\Component\DependencyInjection\ContainerInterface
+   */
+  protected $container;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+
+    $this->container = new ContainerBuilder();
+
+    $string_translation = $this->getStringTranslationStub();
+    $this->container->set('string_translation', $string_translation);
+
+    \Drupal::setContainer($this->container);
+  }
+
+  /**
+   * Test ldap_user_module_preinstall().
+   *
+   * @coversFunction ::ldap_user_module_preinstall
+   */
+  public function testModulePreinstall(): void {
+    require_once __DIR__ . '/../../../ldap_user.module';
+
+    $user_type = $this->createMock('Drupal\Core\Entity\EntityTypeInterface');
+    $user_type->expects($this->once())
+      ->method('id')
+      ->willReturn('user');
+
+    $entity_type_manager = $this->createMock('Drupal\Core\Entity\EntityTypeManagerInterface');
+    $entity_type_manager->expects($this->once())
+      ->method('getDefinition')
+      ->with('user')
+      ->willReturn($user_type);
+
+    $this->container->set('entity_type.manager', $entity_type_manager);
+
+    $field_type = $this->createMock('Drupal\Core\Field\FieldTypePluginManagerInterface');
+    $field_type->expects($this->exactly(7))
+      ->method('getDefaultStorageSettings')
+      ->willReturnMap([
+        ['string', []],
+        ['timestamp', []],
+        ['boolean', []],
+      ]);
+    $field_type->expects($this->exactly(7))
+      ->method('getDefaultFieldSettings')
+      ->willReturnMap([
+        ['string', []],
+        ['timestamp', []],
+        ['boolean', []],
+      ]);
+
+    $this->container->set('plugin.manager.field.field_type', $field_type);
+
+    $definition_update_manager = $this->createMock('Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface');
+    $definition_update_manager->expects($this->exactly(7))
+      ->method('installFieldStorageDefinition');
+    $this->container->set('entity.definition_update_manager', $definition_update_manager);
+
+    ldap_user_module_preinstall('ldap_user');
+  }
+
+  /**
+   * Test ldap_user_update_8401().
+   *
+   * @coversFunction ::ldap_user_update_8401
+   */
+  public function testHookUpdate8401(): void {
+
+    $module_handler = $this->createMock('Drupal\Core\Extension\ModuleHandlerInterface');
+    $module_handler->expects($this->once())
+      ->method('moduleExists')
+      ->with('ldap_query')
+      ->willReturn(FALSE);
+    $this->container->set('module_handler', $module_handler);
+
+    $module_installer = $this->createMock('Drupal\Core\Extension\ModuleInstallerInterface');
+    $module_installer->expects($this->once())
+      ->method('install')
+      ->with(['ldap_query']);
+    $this->container->set('module_installer', $module_installer);
+
+    ldap_user_update_8401();
+  }
+
+  /**
+   * Test ldap_user_update_8402().
+   *
+   * @coversFunction ::ldap_user_update_8402
+   */
+  public function testHookUpdate8402(): void {
+
+    $storage_definition = $this->createMock('Drupal\Core\Field\FieldStorageDefinitionInterface');
+
+    $definition_update_manager = $this->createMock('Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface');
+    $definition_update_manager->expects($this->exactly(7))
+      ->method('getFieldStorageDefinition')
+      ->willReturnMap([
+        ['ldap_user_puid_sid', 'user', $storage_definition],
+        ['ldap_user_puid', 'user', $storage_definition],
+        ['ldap_user_puid_property', 'user', $storage_definition],
+        ['ldap_user_current_dn', 'user', $storage_definition],
+        ['ldap_user_prov_entries', 'user', $storage_definition],
+        ['ldap_user_last_checked', 'user', $storage_definition],
+        ['ldap_user_ldap_exclude', 'user', $storage_definition],
+      ]);
+    $definition_update_manager->expects($this->exactly(7))
+      ->method('updateFieldStorageDefinition')
+      ->with($storage_definition);
+
+    $this->container->set('entity.definition_update_manager', $definition_update_manager);
+
+    ldap_user_update_8402();
+  }
+
+  /**
+   * Test ldap_user_update_8407().
+   *
+   * @coversFunction ::ldap_user_update_8407
+   */
+  public function testHookUpdate8407(): void {
+
+    $cache_default = $this->createMock('Drupal\Core\Cache\CacheBackendInterface');
+    $cache_default->expects($this->once())
+      ->method('deleteAll')
+      ->with();
+    $this->container->set('cache.default', $cache_default);
+
+    $settings = $this->createMock('Drupal\Core\Config\Config');
+
+    $settings->expects($this->exactly(2))
+      ->method('set')
+      ->willReturnMap([
+        ['orphanedIncludeDisabledUsers', FALSE, NULL],
+        ['userUpdateOnly', FALSE, NULL],
+      ]);
+    $settings->expects($this->once())
+      ->method('save');
+
+    $config_factory = $this->createMock('Drupal\Core\Config\ConfigFactoryInterface');
+    $config_factory->expects($this->once())
+      ->method('getEditable')
+      ->with('ldap_user.settings')
+      ->willReturn($settings);
+    $this->container->set('config.factory', $config_factory);
+
+    ldap_user_update_8407();
+  }
+
+  /**
+   * Test ldap_user_update_8408().
+   *
+   * @coversFunction ::ldap_user_update_8408
+   */
+  public function testHookUpdate8408(): void {
+    $settings = $this->createMock('Drupal\Core\Config\Config');
+    $settings->expects($this->once())
+      ->method('get')
+      ->with('acctCreation')
+      ->willReturn('ldap_behaviour');
+    $settings->expects($this->once())
+      ->method('set')
+      ->with('acctCreation', 'ldap_behavior')
+      ->willReturnSelf();
+    $settings->expects($this->once())
+      ->method('save');
+
+    $config_factory = $this->createMock('Drupal\Core\Config\ConfigFactoryInterface');
+    $config_factory->expects($this->once())
+      ->method('getEditable')
+      ->with('ldap_user.settings')
+      ->willReturn($settings);
+    $this->container->set('config.factory', $config_factory);
+
+    ldap_user_update_8408();
+  }
+
+  /**
+   * Test ldap_user_update_8408().
+   *
+   * @coversFunction ::ldap_user_update_8408
+   */
+  public function testHookUpdate8408Behavior(): void {
+    $settings = $this->createMock('Drupal\Core\Config\Config');
+    $settings->expects($this->once())
+      ->method('get')
+      ->with('acctCreation')
+      ->willReturn('ldap_behavior');
+
+    $config_factory = $this->createMock('Drupal\Core\Config\ConfigFactoryInterface');
+    $config_factory->expects($this->once())
+      ->method('getEditable')
+      ->with('ldap_user.settings')
+      ->willReturn($settings);
+    $this->container->set('config.factory', $config_factory);
+
+    ldap_user_update_8408();
+  }
+
+}