Skip to content
Snippets Groups Projects

Fixed the code standards.

3 unresolved threads

Closes #3372204

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
5 5 core_version_requirement: ^8.7.7 || ^9 || ^10
6 6 dependencies:
7 7 - drupal:y_branch
8 - y_lb
9
8 - drupal:y_lb
  • this is not correct. There is no such module at drupal.org - never fully trust automated tools

    Suggested change
    8 - drupal:y_lb
    8 - y_lb
  • Actually, there isn't any project on https://www.drupal.org/project/y_lb. That dependency should not have been added. The change in this MR is wrong, since Drupal core does not have any module whose machine name is y_lb.

    Edited by Alberto Paderno
  • There are projects outside of drupal.org and dependency is correct. Drupal modules are not only projects, hosted on drupal.org There is a composer which helps to collect dependencies, y_lb is hosted at github and managed by composer in order to be collected for dependency to be solved. No error here

  • Please register or sign in to reply
  • 45 $this->branchHoursHelper = $branchHoursHelper;
    46 $this->entityTypeManager = $entityTypeManager;
    47 }
    48
    49 /**
    50 * Create method to instantiate the class.
    51 *
    52 * @param \Symfony\Component\DependencyInjection\ContainerInterface $container
    53 * The dependency injection container.
    54 *
    55 * @return static
    56 * The instantiated object.
    57 */
    58 public static function create(ContainerInterface $container) {
    59 $entityTypeManager = $container->get('entity_type.manager');
    60 return new static($entityTypeManager);
  • Please, do not fully trust automated tools This code is not functional, needs work

  • 18 17 $output = '';
    19 18 $output .= '<h3>' . t('About') . '</h3>';
    20 19 $output .= '<p>' . t('Provides the Layout Builder Hours Blocks.') . '</p>';
    21 $output .= '<p>'. t('For more information related to module please visit <a href="https://www.drupal.org/project/lb_branch_hours_blocks" target="_blank">project page</a>') . '</p>';
    20 $output .= '<p>' . t('For more information related to module please visit <a href="https://www.drupal.org/project/lb_branch_hours_blocks" target="_blank">project page</a>') . '</p>';
  • Closing for no activity

  • Nikolay Shapovalov mentioned in merge request !22 (closed)

    mentioned in merge request !22 (closed)

  • Please register or sign in to reply
    Loading