Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
layout_paragraphs
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
layout_paragraphs
Commits
1013cfce
Commit
1013cfce
authored
3 years ago
by
Justin Toupin
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3257666
: Misleading dialog title for "Delete" action
parent
1cbacf1c
No related branches found
No related tags found
1 merge request
!103
Issue #3295875: Add a new dedicated permission for Layout paragraphs configurations
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
layout_paragraphs.module
+1
-0
1 addition, 0 deletions
layout_paragraphs.module
src/Form/DeleteComponentForm.php
+2
-2
2 additions, 2 deletions
src/Form/DeleteComponentForm.php
with
3 additions
and
2 deletions
layout_paragraphs.module
+
1
−
0
View file @
1013cfce
...
...
@@ -247,6 +247,7 @@ function layout_paragraphs_preprocess_layout_paragraphs_builder_controls(&$varia
'modal'
=>
TRUE
,
'target'
=>
Dialog
::
dialogId
(
$layout
),
'dialogClass'
=>
'lpb-dialog'
,
'width'
=>
'auto'
,
]),
'title'
=>
t
(
'Delete'
),
],
...
...
This diff is collapsed.
Click to expand it.
src/Form/DeleteComponentForm.php
+
2
−
2
View file @
1013cfce
...
...
@@ -65,9 +65,9 @@ class DeleteComponentForm extends FormBase {
$this
->
componentUuid
=
$component_uuid
;
$component
=
$this
->
layoutParagraphsLayout
->
getComponentByUuid
(
$this
->
componentUuid
);
$type
=
$component
->
getEntity
()
->
getParagraphType
()
->
label
();
$form
[
'#title'
]
=
$this
->
t
(
'Delete
@type
'
,
[
'@type'
=>
$type
]);
$form
[
'#title'
]
=
$this
->
t
(
'Delete
component
'
,
[
'@type'
=>
$type
]);
$form
[
'confirm'
]
=
[
'#markup'
=>
$this
->
t
(
'Really delete this @type? There is no undo.'
,
[
'@type'
=>
$type
]),
'#markup'
=>
$this
->
t
(
'Really delete this
"
@type
" component
? There is no undo.'
,
[
'@type'
=>
$type
]),
];
$form
[
'actions'
]
=
[
'#type'
=>
'actions'
,
...
...
This diff is collapsed.
Click to expand it.
Justin Toupin
@justin2pin
mentioned in commit
f11744f3
·
1 year ago
mentioned in commit
f11744f3
mentioned in commit f11744f3733a24df996ec39c11f9e4add4c285ae
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment