Skip to content
Snippets Groups Projects

Issue #3497914: Make tests run on GitLab CI.

2 unresolved threads

Issue #3420063 by justcaldwell, mohd sahzad, webfaqtory, eugeney, andikanio, slayne40, mellowtothemax, joseph.olstad, handkerchief, carolpettirossi, guido_s, junkuncz, chuck_theobald, millerrs, anybody, bsingh, kevin-jhonatan, s_leu, grevil, joe_carvajal, urmoucher, captain_canuck, avinashm, igorgoncalves: Error: Call to a member function getConfig() OverridesSectionStorage.php

Closes #3497914

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
28 if (!$entity || !$entity->hasField(static::FIELD_NAME)) {
29 // Return a neutral result if the entity is null.
30 return AccessResult::neutral();
31 }
32
26 33 $field_config = $entity->getFieldDefinition(static::FIELD_NAME)->getConfig($entity->bundle());
27 // Access is allow if one of the following conditions is true:
34
35 // Access is allowed if one of the following conditions is true:
28 36 // 1. This is the default translation.
29 37 // 2. The entity is translatable and the layout is overridden and the layout
30 38 // field is not translatable.
31 return $result->andIf(AccessResult::allowedIf($this->isDefaultTranslation() || ($entity instanceof TranslatableInterface && $this->isOverridden() && !$field_config->isTranslatable())))->addCacheableDependency($entity)->addCacheableDependency($field_config);
39 return $result->andIf(AccessResult::allowedIf($this->isDefaultTranslation() || ($entity instanceof TranslatableInterface && $this->isOverridden() && !$field_config->isTranslatable())))
40 ->addCacheableDependency($entity)
41 ->addCacheableDependency($field_config);
  • 185 184 */
    186 185 private static function hasTranslatableConfiguration(SectionComponent $component) {
    187 186 $plugin = $component->getPlugin();
    188 if ($plugin instanceof LayoutBuilderTranslatablePluginInterface) {
    189 return $plugin->hasTranslatableConfiguration();
    190 }
    191 elseif ($plugin instanceof ConfigurableInterface) {
    192 // For all plugins that do not implement
    193 // LayoutBuilderTranslatablePluginInterface only allow label translation.
    187 if ($plugin instanceof ConfigurableInterface) {
    188 // For all plugins of ConfigurableInterface, only allow label translation.
    194 189 $configuration = $plugin->getConfiguration();
    195 190 return !empty($configuration['label_display']) && !empty($configuration['label']);
  • Joseph Olstad added 1 commit

    added 1 commit

    • 7f6d8790 - Revert "Issue #3420063 by justcaldwell, mohd sahzad, webfaqtory, eugeney,...

    Compare with previous version

  • Joseph Olstad changed title from Issue #3420063 by justcaldwell, mohd sahzad, webfaqtory, eugeney, andikanio,... to Issue #3497914: Make tests run on GitLab CI.

    changed title from Issue #3420063 by justcaldwell, mohd sahzad, webfaqtory, eugeney, andikanio,... to Issue #3497914: Make tests run on GitLab CI.

  • Joseph Olstad added 1 commit

    added 1 commit

    • 95902723 - Revert "phpstan fix for LayoutBuilderTranslatablePluginInterface not found"

    Compare with previous version

  • Joseph Olstad added 1 commit

    added 1 commit

    Compare with previous version

  • Joseph Olstad added 1 commit

    added 1 commit

    • 421be7c4 - Revert "Let's see what this does."

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading