Issue #3431600: Automated Drupal 11 compatibility fixes for layout_builder_st
Closes #3431600
Merge request reports
Activity
- Resolved by Joshua Sedler
17 17 # Override the class resolver to so that InlineBlockEntityOperations can be swapped to the extend version. 18 18 class_resolver: 19 19 class: Drupal\layout_builder_st\DependencyInjection\ClassResolver 20 calls: 21 - [setContainer, ['@service_container']] 20 arguments: ['@service_container'] 21 Drupal\Core\DependencyInjection\ClassResolverInterface: '@class_resolver' - Comment on lines 19 to +21
I'm not sure this should be overridden outright; since the class resolver has an interface, a decorator would be the preferred approach here. Overriding is more fragile because if something else overrides the same service, this module may break or behave in an unexpected way. Decoration is more resilient.
Edited by Adam G-H changed this line in version 4 of the diff
Ok this doesn't work yet. See my comment in the issue @phenaproxima here
- Resolved by Joshua Sedler
87 87 88 88 return $requirements; 89 89 } 90 91 /** 92 * Rebuilding container, because of D11 related services.yml changes. 93 */ 94 function layout_builder_st_update_10001() { 95 \Drupal::service('kernel')->rebuildContainer(); I could be wrong here but doesn't an empty update hook cause a cache clear/container rebuild? @tim.plunkett would know.
My understanding is that the container is rebuilt for every post-update hook:
added 1 commit
- cfd7d837 - Add new decorator class resolver, remove unnecessary elementmanager and remove unrelated changes
added 1 commit
added 1 commit
added 1 commit
added 1 commit
added 1 commit
- 4e69d605 - Require the system module and layout_builder.
added 1 commit
added 1 commit
Please register or sign in to reply