Skip to content
Snippets Groups Projects

issue fixed

Merged issue fixed
issue/layout_builder_lock-3398496:3398496-fix-phpcs-warnings into 8.x-1.x
All threads resolved!
Merged chetan requested to merge issue/layout_builder_lock-3398496:3398496-fix-phpcs-warnings into 8.x-1.x
All threads resolved!

phpcs issue fixed #3398496

Merge request reports

Merged results pipeline #55818 passed with warnings

Stage: build
Stage: validate
Stage: test

Merged results pipeline passed with warnings for 930a36e6

Approved by
Yurii Panchuk
Code Quality is loading
Test summary results are being parsed
Full report

Merged by Yurii PanchukYurii Panchuk 1 year ago (Nov 27, 2023 7:46pm UTC)

Merge details

  • Changes merged into 8.x-1.x with 75a5257f (commits were squashed).
  • Did not delete the source branch.

Pipeline #55821 passed with warnings

Stage: build
Stage: validate
Stage: test

Pipeline passed with warnings for 75a5257f on 8.x-1.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yurii Panchuk
  • Yurii Panchuk
  • Yurii Panchuk
  • Yurii Panchuk
  • Yurii Panchuk
  • Yurii Panchuk
  • Yurii Panchuk
    Yurii Panchuk @Panchuk
    Maintainer

    @chetan-11 thanks!

    The code looks much better. Tests are green, but there a few code styling problems found in MR.

    Also, you have changed some variable's names but forgot to update them in the code.

  • chetan added 1 commit

    added 1 commit

    Compare with previous version

  • Yurii Panchuk added 4 commits

    added 4 commits

    Compare with previous version

    Toggle commit list
  • Yurii Panchuk added 2 commits

    added 2 commits

    Compare with previous version

  • Yurii Panchuk resolved all threads

    resolved all threads

  • Yurii Panchuk added 1 commit

    added 1 commit

    Compare with previous version

  • Yurii Panchuk added 1 commit

    added 1 commit

    Compare with previous version

  • Yurii Panchuk approved this merge request

    approved this merge request

  • Yurii Panchuk merged

    merged

    • Please register or sign in to reply