Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
J
jsonrpc
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
jsonrpc
Merge requests
!10
php 8.1: Argument
#1
($rpc_responses) must be of type array, null given
Code
Review changes
Check out branch
Download
Patches
Plain diff
Open
php 8.1: Argument
#1
($rpc_responses) must be of type array, null given
issue/jsonrpc-3285339:fix_response_header
into
2.x
Overview
0
Commits
3
Pipelines
3
Changes
1
Open
Patrick Kenny
requested to merge
issue/jsonrpc-3285339:fix_response_header
into
2.x
1 year ago
Overview
0
Commits
3
Pipelines
3
Changes
1
Expand
0
0
Merge request reports
Compare
2.x
version 3
46a93d01
6 months ago
version 2
7e3fbb18
6 months ago
version 1
33a0b61b
1 year ago
2.x (HEAD)
and
latest version
latest version
25f86189
3 commits,
6 months ago
version 3
46a93d01
2 commits,
6 months ago
version 2
7e3fbb18
1 commit,
6 months ago
version 1
33a0b61b
1 commit,
1 year ago
1 file
+
5
−
6
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/Controller/HttpController.php
+
5
−
6
Options
@@ -162,15 +162,14 @@ class HttpController extends ControllerBase {
try
{
$rpc_responses
=
$this
->
getRpcResponses
(
$rpc_requests
);
// Aggregate the response headers so we can add them to the HTTP response.
$header_bag
=
$this
->
aggregateResponseHeaders
(
$rpc_responses
);
// If no RPC response(s) were generated (happens if all of the request(s)
// were notifications), then return a 204 HTTP response.
if
(
empty
(
$rpc_responses
))
{
$response
=
new
CacheableJsonResponse
(
NULL
,
Response
::
HTTP_NO_CONTENT
);
$response
->
headers
->
add
(
$header_bag
->
all
());
return
$response
;
return
new
CacheableJsonResponse
(
NULL
,
Response
::
HTTP_NO_CONTENT
);
}
else
{
// Aggregate the response headers to add them to the HTTP response.
$header_bag
=
$this
->
aggregateResponseHeaders
(
$rpc_responses
);
}
// Map the RPC response(s) to an HTTP response.
Loading