Issue #3435832 by gaurav_manerkar, ankitv18, bbrala: Fixed errors reported by CSpell job

.gitlab-ci.yml

@@ -48,6 +48,9 @@ include:
 ################
 variables:
   SKIP_ESLINT: '1'
+  # Ignore logo.psd file from cspell check.
+  _CSPELL_IGNORE_PATHS: "\"logo.psd\""
+
 
 
 ###################################################################################

jsonapi_extras.install

 <?php
 
-declare(strict_types=1);
-
-use Drupal\Core\Config\ConfigFactoryInterface;
-
 /**
  * @file
  * Module installation file.
  */
 
+declare(strict_types=1);
+
+use Drupal\Core\Config\ConfigFactoryInterface;
+
 /**
  * Implements hook_update_N().
  */

modules/jsonapi_defaults/jsonapi_defaults.module

@@ -70,7 +70,7 @@ function _jsonapi_defaults_form_alter(array &$form, FormStateInterface $form_sta
     '#default_value' => $filters,
     '#description' => t('Enter one filter per line, in the format key=value. For example:<br />
         filter[titleFilter][condition][path]=title<br />
-        filter[titleFilter][condition][value]=Comis Commodo Ymo<br />
+        filter[titleFilter][condition][value]=value<br />
         If a request contains an "filter" query string parameter those filters will be added to the defaults.'),
   ];
 
@@ -104,7 +104,7 @@ function _jsonapi_defaults_form_alter(array &$form, FormStateInterface $form_sta
  */
 function jsonapi_defaults_form_jsonapi_resource_config_form_builder($entity_type, JsonapiResourceConfig $config_resource, &$form, FormStateInterface $form_state) {
   if ($raw_value = $form_state->getValue('default_filter')) {
-    $value = _jsonapi_defaults_convert_rawvalue($raw_value);
+    $value = _jsonapi_defaults_convert_raw_value($raw_value);
     $config_resource->setThirdPartySetting('jsonapi_defaults', 'default_filter', $value);
   }
   else {
@@ -112,7 +112,7 @@ function jsonapi_defaults_form_jsonapi_resource_config_form_builder($entity_type
   }
 
   if ($raw_value = $form_state->getValue('default_sorting')) {
-    $value = _jsonapi_defaults_convert_rawvalue($raw_value);
+    $value = _jsonapi_defaults_convert_raw_value($raw_value);
     $config_resource->setThirdPartySetting('jsonapi_defaults', 'default_sorting', $value);
   }
   else {
@@ -145,7 +145,7 @@ function jsonapi_defaults_form_jsonapi_resource_config_form_builder($entity_type
  * @return array
  *   Value to be saved into config.
  */
-function _jsonapi_defaults_convert_rawvalue($raw_value) {
+function _jsonapi_defaults_convert_raw_value($raw_value) {
   $value = [];
   $raw_value = (!is_string($raw_value)) ? '' : $raw_value;
   foreach (preg_split('/\r\n|[\r\n]/', $raw_value) as $param) {

modules/jsonapi_defaults/src/Controller/EntityResource.php

@@ -12,7 +12,7 @@ use Drupal\Core\Render\RendererInterface;
 use Drupal\Core\Session\AccountInterface;
 use Drupal\jsonapi\Access\EntityAccessChecker;
 use Drupal\jsonapi\Context\FieldResolver;
-use Drupal\jsonapi\Controller\EntityResource as JsonApiEntityResourse;
+use Drupal\jsonapi\Controller\EntityResource as JsonApiEntityResource;
 use Drupal\jsonapi\IncludeResolver;
 use Drupal\jsonapi\Query\OffsetPage;
 use Drupal\jsonapi\Query\Sort;
@@ -26,7 +26,7 @@ use Symfony\Component\Serializer\SerializerInterface;
 /**
  * Overrides jsonapi module EntityResource controller.
  */
-class EntityResource extends JsonApiEntityResourse {
+class EntityResource extends JsonApiEntityResource {
 
   /**
    * The jsonapi defaults service.

modules/jsonapi_defaults/tests/src/Functional/JsonApiDefaultsFunctionalTest.php

@@ -31,7 +31,7 @@ class JsonApiDefaultsFunctionalTest extends JsonApiExtrasFunctionalTestBase {
    * Test regression on sorting from issue 3322635.
    */
   public function testSortRegression3322635() {
-    $this->setResouceConfigValue([
+    $this->setResourceConfigValue([
       'default_filter' => [],
       'default_sorting' => [],
     ]);
@@ -111,7 +111,7 @@ class JsonApiDefaultsFunctionalTest extends JsonApiExtrasFunctionalTestBase {
 
     // 4. Using the default sorting check the order.
     // Unset filters of resource config in this test as those limit the results.
-    $this->setResouceConfigValue(['default_filter' => []]);
+    $this->setResourceConfigValue(['default_filter' => []]);
     $this->nodes[0]->setTitle('a');
     $this->nodes[0]->save();
 
@@ -160,7 +160,7 @@ class JsonApiDefaultsFunctionalTest extends JsonApiExtrasFunctionalTestBase {
    */
   public function testPagination() {
     // Unset filters of resource config in this test as those limit the results.
-    $this->setResouceConfigValue(['default_filter' => []]);
+    $this->setResourceConfigValue(['default_filter' => []]);
     $this->createDefaultContent(300, 1, FALSE, TRUE, static::IS_NOT_MULTILINGUAL);
 
     // 1. Check pagination using default page limit of jsonapi.
@@ -168,7 +168,7 @@ class JsonApiDefaultsFunctionalTest extends JsonApiExtrasFunctionalTestBase {
     $this->assertPagination(Json::decode($response), OffsetPage::SIZE_MAX);
 
     // 2. Check with an increased page limit.
-    $this->setResouceConfigValue(['page_limit' => static::PAGE_LIMIT_OVERRIDE_VALUE]);
+    $this->setResourceConfigValue(['page_limit' => static::PAGE_LIMIT_OVERRIDE_VALUE]);
     $response = $this->drupalGet('/api/articles', [
       'query' => ['page[limit]' => static::PAGE_LIMIT_OVERRIDE_VALUE],
     ]);
@@ -252,7 +252,7 @@ class JsonApiDefaultsFunctionalTest extends JsonApiExtrasFunctionalTestBase {
    *
    * @throws \Drupal\Core\Entity\EntityStorageException
    */
-  protected function setResouceConfigValue(array $values) {
+  protected function setResourceConfigValue(array $values) {
     $resource_config = JsonapiResourceConfig::load('node--article');
     foreach ($values as $key => $value) {
       $resource_config->setThirdPartySetting('jsonapi_defaults', $key, $value);

templates/expandable-rows-table.html.twig

@@ -37,7 +37,7 @@
  *   any rows.
  * - no_striping: A boolean indicating that the row should receive no striping.
  * - header_columns: The number of columns in the header.
- * - toggler_text: Text of the link that shows/hides the colapsible row
+ * - toggler_text: Text of the link that shows/hides the collapsible row
  *
  * @see template_preprocess_table()
  */

tests/src/Kernel/DefaultDisabledResourceConfigTest.php

@@ -44,14 +44,14 @@ class DefaultDisabledResourceConfigTest extends KernelTestBase {
    * Tests the default disabled setting.
    */
   public function testDefaultDisabled(): void {
-    $resource_respository = $this->container->get('jsonapi.resource_type.repository');
-    assert($resource_respository instanceof ConfigurableResourceTypeRepository);
-    $resource = $resource_respository->get('entity_test', 'entity_test');
+    $resource_repository = $this->container->get('jsonapi.resource_type.repository');
+    assert($resource_repository instanceof ConfigurableResourceTypeRepository);
+    $resource = $resource_repository->get('entity_test', 'entity_test');
     $this->assertFalse($resource->isInternal());
     $this->config('jsonapi_extras.settings')->set('default_disabled', TRUE)->save();
-    $resource_respository->reset();
+    $resource_repository->reset();
     Cache::invalidateTags(['jsonapi_resource_types']);
-    $resource = $resource_respository->get('entity_test', 'entity_test');
+    $resource = $resource_repository->get('entity_test', 'entity_test');
     $this->assertTrue($resource->isInternal());
     JsonapiResourceConfig::create([
       'id' => 'entity_test--entity_test',
@@ -61,7 +61,7 @@ class DefaultDisabledResourceConfigTest extends KernelTestBase {
       'resourceFields' => [],
     ])->save();
     Cache::invalidateTags(['jsonapi_resource_types']);
-    $resource = $resource_respository->get('entity_test', 'entity_test');
+    $resource = $resource_repository->get('entity_test', 'entity_test');
     $this->assertFalse($resource->isInternal());
   }