Skip to content
Snippets Groups Projects
Joshua Sedler's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Ok! Makes sense :)

Jan Kellermann's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

The behavior is unchanged, the module already handled this way before. Apart from that, I completely agree with you - but it goes beyond the scope ...

Jan Kellermann's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Added link. Thank you!

Jan Kellermann's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Added "extra" wrappers.

Jan Kellermann's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Fixed in commit.

Jan Kellermann's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Fixed.

Jan Kellermann's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

There are more countries and regions than the EU that have data protection laws, so I have kept this general. See also https://unctad.org/page/data...

Joshua Sedler's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

This could be debatable. I am a big fan of having a select or checkbox in place to actively enable cdn, instead of it being a fallback. But since w...

Joshua Sedler's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Let's add a link on how to set asset-packagist up: https://www.drupal.org/docs/develop/using-composer/manage-dependencies#third-party-libraries

Joshua Sedler's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Let's wrap this in "extra" so the user doesn't think this needs to go in the bottom level.

Joshua Sedler's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

"web" doesn't have to be on the same level as "themes" and "modules" and "libraries" can also have a different location.

Joshua Sedler's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

"[...] and respect the General Data Protection Regulation." Would be better here I think....

Sharique Farooqui's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Oh, I see it is used in hook.

Sharique Farooqui's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

How does the directory property works? I didn't find in the documentation. And it should be /libraries/js-cookie not cookies.

Julian Pustkuchen's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

I think this sentence can be improved to clarify it's currently loading from CDN already?...

Julian Pustkuchen's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

Perhaps better "from the local libraries directory"?

Julian Pustkuchen's avatar
commented on merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie

/libraries/js-cookies vs. /libraries/js-cookie/dist/js.cookie.min.js (below)

Jan Kellermann's avatar
opened merge request !2 "Resolve #3390616 "Composer libraries"" at project / js_cookie
ressa's avatar
commented on merge request !1 "Issue #3390616: Support local library file" at project / js_cookie

Great suggestion @RoSk0, I added the one-liner.

Kirill Roskolii's avatar
commented on merge request !1 "Issue #3390616: Support local library file" at project / js_cookie

Why not add this instructions curl --create-dirs -o libraries/js-cookie/dist/js.cookie.min.js https://cdn.jsdelivr.net/npm/js-cookie@3.0.5/dist/js....