Issue #2994535 by Steven Jones: Processors are broken

imageapi_optimize_binaries.services.yml

 services:
-  imageapi_optimize.shell_operations:
-    class: Drupal\imageapi_optimize\ShellOperations
+  imageapi_optimize_binaries.shell_operations:
+    class: Drupal\imageapi_optimize_binaries\ShellOperations

src/ImageAPIOptimizeProcessorBinaryBase.php

 <?php
 
-namespace Drupal\imageapi_optimize;
+namespace Drupal\imageapi_optimize_binaries;
 
 use Drupal\Core\File\FileSystemInterface;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Image\ImageFactory;
+use Drupal\imageapi_optimize\ConfigurableImageAPIOptimizeProcessorBase;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
@@ -23,7 +24,7 @@ abstract class ImageAPIOptimizeProcessorBinaryBase extends ConfigurableImageAPIO
   /**
    * The imageapi shell operation service.
    *
-   * @var \Drupal\imageapi_optimize\ImageAPIOptimizeShellOperationsInterface
+   * @var \Drupal\imageapi_optimize_binaries\ImageAPIOptimizeShellOperationsInterface
    */
   protected $shellOperations;
 
@@ -48,7 +49,7 @@ abstract class ImageAPIOptimizeProcessorBinaryBase extends ConfigurableImageAPIO
       $container->get('logger.factory')->get('imageapi_optimize'),
       $container->get('image.factory'),
       $container->get('file_system'),
-      $container->get('imageapi_optimize.shell_operations')
+      $container->get('imageapi_optimize_binaries.shell_operations')
     );
   }
 

src/ImageAPIOptimizeShellOperationsInterface.php

+<?php
+
+namespace Drupal\imageapi_optimize_binaries;
+
+interface ImageAPIOptimizeShellOperationsInterface {
+  public function findExecutablePath($executable = NULL);
+  public function execShellCommand($command, $options, $arguments);
+  public function saveCommandStdoutToFile($cmd, $dst);
+}

src/Plugin/ImageAPIOptimizeProcessor/AdvDef.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
 use Drupal\Core\Form\FormStateInterface;
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the AdvDef binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/AdvPng.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
 use Drupal\Core\Form\FormStateInterface;
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the AdvPng binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/JfifRemove.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the JfifRemove binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/JpegOptim.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
 use Drupal\Core\Form\FormStateInterface;
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the JpegOptim binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/JpegTran.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
 use Drupal\Core\Form\FormStateInterface;
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the JpegTran binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/OptiPng.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
 use Drupal\Core\Form\FormStateInterface;
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the OptiPng binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/PngCrush.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the PngCrush binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/PngOut.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the PngOut binary to optimize images.

src/Plugin/ImageAPIOptimizeProcessor/PngQuant.php

 <?php
 
-namespace Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor;
+namespace Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor;
 
-use Drupal\imageapi_optimize\ImageAPIOptimizeProcessorBinaryBase;
+use Drupal\imageapi_optimize_binaries\ImageAPIOptimizeProcessorBinaryBase;
 
 /**
  * Uses the PngQuant binary to optimize images.

src/ShellOperations.php

 <?php
 
-namespace Drupal\imageapi_optimize;
+namespace Drupal\imageapi_optimize_binaries;
 
 
 /**

tests/src/Unit/AdvDefTest.php

@@ -2,7 +2,7 @@
 
 namespace Drupal\Tests\imageapi_optimize\Unit;
 
-use Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor\AdvDef;
+use Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor\AdvDef;
 
 /**
  * Tests AdvDef image optimize plugin.

tests/src/Unit/AdvPngTest.php

@@ -2,7 +2,7 @@
 
 namespace Drupal\Tests\imageapi_optimize\Unit;
 
-use Drupal\imageapi_optimize\Plugin\ImageAPIOptimizeProcessor\AdvPng;
+use Drupal\imageapi_optimize_binaries\Plugin\ImageAPIOptimizeProcessor\AdvPng;
 
 /**
  * Tests AdvPng image optimize plugin.

tests/src/Unit/BinaryTestCase.php

@@ -30,7 +30,7 @@ abstract class BinaryTestCase extends UnitTestCase {
   }
 
   protected function getShellOperationsMock() {
-    $shellOperationsMock =  $this->getMockBuilder('\Drupal\imageapi_optimize\ImageAPIOptimizeShellOperationsInterface')
+    $shellOperationsMock =  $this->getMockBuilder('\Drupal\imageapi_optimize_binaries\ImageAPIOptimizeShellOperationsInterface')
       ->setMethods(['findExecutablePath', 'execShellCommand', 'saveCommandStdoutToFile'])
       ->getMock();