Skip to content

Issue #3456355 by DYdave: Reverted module's Gitlab CI config to use default...

David Suissa requested to merge issue/image_link_formatter-3456355:3456355-create-stable-release into 2.2.x

https://www.drupal.org/project/image_link_formatter/issues/3456355

GitLab CI configuration updates:

  • Reverted module's Gitlab CI config to use default workflow.
  • Updated template file based on template gitlab-ci/template.gitlab-ci.yml current version.
  • Added OPT_IN variables to broaden tests coverage.
  • Required all jobs to pass: cspell, eslint, phpcs and phpstan.

Fixed phpstan validation errors for next major job: https://git.drupalcode.org/issue/image_link_formatter-3456355/-/jobs/1925302#L45

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ -------------------------------------------------------------------------------- 
  Line   tests/src/Traits/Functional/ImageLinkFormatterTestTrait.php (in                 
         context of class                                                                
         Drupal\Tests\image_link_formatter\Functional\ImageLinkFormatterTest)            
 ------ -------------------------------------------------------------------------------- 
  104    Access to an undefined property                                                 
         Drupal\Tests\image_link_formatter\Functional\ImageLinkFormatterTest::$display.  
         💡 Learn more:                                                                  
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property        
 ------ -------------------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/Functional/ImageLinkFormatterTestTrait.php (in                                      
         context of class                                                                                     
         Drupal\Tests\responsive_image_link_formatter\Functional\ResponsiveImageLinkFormatterTest)            
 ------ ----------------------------------------------------------------------------------------------------- 
  104    Access to an undefined property                                                                      
         Drupal\Tests\responsive_image_link_formatter\Functional\ResponsiveImageLinkFormatterTest::$display.  
         💡 Learn more:                                                                                       
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                             
 ------ ----------------------------------------------------------------------------------------------------- 
 [ERROR] Found 2 errors

Merge request reports