An error occurred while fetching the assigned milestone of the selected merge_request.
issue #3296192 by Dharti Patel: PHPCS Coding Standards Issue
Hi, I applied 3296192-updating-cs-10.patch and found coding standard errors remaining, so I just worked on them. About the README file, there is no need to fix its coding standards issues because it has a structure defined to explain all about the module. Now there are 2 coding standards errors remaining which need some clarification before work on them:
FILE: /-------/------/------/-------/-------/-------/modules/contrib/image_effects/tests/src/Functional/SettingsFormTest.php
FOUND 1 ERROR AFFECTING 1 LINE
97 | ERROR | Method name "SettingsFormTest::__testJqueryColorpickerSelector" is invalid; only PHP magic methods should be prefixed with a double underscore
FILE: /---/---/---/---/---/---/modules/contrib/image_effects/tests/src/Functional/Effect/RotateTest.php
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
258 | WARNING | Unused private method setFuchsia() 275 | WARNING | Unused private method setTransparent() 294 | WARNING | Unused private method shift90()
Merge request reports
Activity
added 3 commits
-
b7ba2161...b8b20f92 - 2 commits from branch
project:8.x-3.x
- 1bb9e118 - Merge branch '8.x-3.x' into 3296192-phpcs-coding-standards
-
b7ba2161...b8b20f92 - 2 commits from branch
added 1 commit
- 42b0dae3 - return skiped test and null coalesce operator
Please register or sign in to reply