fix: #3622112 Rename user 1 so the functional suite can log in, and shorten the two job names

Rajab Natshahrequested to merge
issue/horizonaid-3622112:3622112-installer-account-name-and-job-names into 1.0.x

Issue: #3622112 The functional suite cannot log in because the Drupal CMS installer ignores --account-name, and rename the two pipeline jobs

What this changes

.gitlab-ci.yml only (+20 / -8):

  1. After the site is installed, rename user 1 to $DRUPAL_ADMIN_USERNAME and set its password explicitly.
  2. Rename 🧩 (Drupal CMS) Install Horizon Aid site template to 🧩 Drupal CMS - Horizon Aid, and 🧪 Functional testing to 🧪 Functional.

Why

On the first full run of the single-host pipeline from #3622094, the install job passed but 9 of the 18 functional buckets failed: 09-editorial-a, 09-editorial-b, 09-editorial-c, 10-01-canvas-pages-listed, 10-02-canvas-home-about, 10-03-canvas-countries-programs, 10-04-canvas-resources-events, 10-05-canvas-impact-donate, 12-search. The 9 that passed are exactly the ones that never log in.

Every failure is the same step and the same cause:

Given I am a logged in user with the "webmaster" user   PASS
Then I should see "Log out"                             FAIL
locator.waitFor: Timeout 5000ms exceeded
  waiting for locator('body').filter({ hasText: 'Log out' }) to be visible

The Drupal CMS installer's "Create your account" step has no username field. Verified in a real browser: its only inputs are account[mail], account[pass] and date_default_timezone. So --account-name is silently ignored and user 1 is always admin, while cucumber.js defines the suite's users as webmaster / dD.123123ddd.

Confirmed on two freshly built Drupal CMS sites, one installed with drush site:install recipes/horizonaid and one through the full browser installer: User::load(1)->getAccountName() returns admin in both.

This did not surface before because the removed varbase_project lane installed on a Varbase host, where --account-name IS honoured.

Verification

  • On a freshly built Drupal CMS site with Horizon Aid installed, renaming user 1 to webmaster and setting the password makes the login work. Driven in a real browser it lands on /admin/dashboard with "Log out" present, which is exactly the step that was failing.
  • The rewritten pipeline is accepted by the GitLab CI lint API (valid: true).

Note for reviewers: a separate, more serious defect found while verifying this, NOT fixed here

Installing Horizon Aid through the browser installer breaks part-way. It stops around "Completed 41 of 123", still redirects to /admin/dashboard/welcome, and leaves a site-wide HTTP 500 with only 77 of 245 modules installed. vartheme_bs5_horizonaid and redirect are missing while redirect.settings and views.view.redirect* were imported, so the first fatal is PluginNotFoundException: The "redirect" entity type does not exist. Both drush-driven paths complete cleanly on the same codebase. That appears to be the already-filed #3620718 and is out of scope here.

AI disclosure

AI-Generated: Yes

Assisted by Claude Code (Claude Opus 5). Verified by a human-run local install and a real browser login, plus the GitLab CI lint API.

Checkpoints:

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • UX/UI designer responsibilities
  • Readability
  • Accessibility
  • Performance
  • Security
  • Developer Documentation
  • User Guide Documentation
  • Reviewed by human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Release notes snippet
  • Release

🤖 Generated with Claude Code

Edited by Rajab Natshah

Merge request reports