fix: #3620330 Remove the Varbase Dev Base requirement
What this does
One line removed from composer.json:
- "drupal/varbase_dev_base": "1.0.x-dev",Nothing else. recipe.yml is untouched, because it never referenced varbase_dev_base in the first place — verified, 0 matches.
Why
The recipe was required but never applied. It is absent from recipe.yml's recipes: list, so requiring it bought nothing and only pulled its dependencies into every install of a production site template: devel, devel_entity_updates, sdc_devel, stage_file_proxy, reroute_email, config_update, config_ignore and storybook.
Varbase Dev Base's own description is "Development Environment Modules, make sure to disable them in production."
And it is not merely dead weight — it breaks installation on a stock Drupal CMS base:
drupal/horizonaid 1.0.x-dev
→ requires drupal/varbase_dev_base 1.0.x-dev
→ requires drupal/storybook ~1.0
→ requires symfony/css-selector ^4 || ^6 || ^7
but drupal/cms locks symfony/css-selector at v8.1.6Drupal core 11.4.5 does not require css-selector at all, so Drupal CMS had simply drifted up to v8.1.6 with nothing holding it down. Unlocked, the tree resolves to symfony/css-selector v7.4.18 and installs cleanly.
Testing
Reproduced and diagnosed, but this exact branch has not been installed end to end. Being straight about what was and was not run:
- Reproduced the resolve failure with the documented steps on a clean
drupal/cmsbuild (~/workspace/test/my-drupal-site-ha1), and captured the full Composer conflict output. - Confirmed three workarounds all resolve —
-W, deletingcomposer.lock, or a rootsymfony/css-selector: ^7pin — and that the unlocked tree lands onv7.4.18withdrupal/storybook 1.0.4anddrupal/core 11.4.5. - Confirmed
recipe.ymlhas novarbase_dev_basereference on1.0.x, so removing the requirement cannot change what the recipe applies. - Not run: a full browser install of this branch. The change is a Composer-metadata removal that cannot affect recipe application, but that reasoning is not a substitute for an install, so
Testing to ensure no regressionstays unticked.
Scope note
The same pattern exists in Educare and Varbase Starter — varbase_dev_base required in composer.json, absent from recipe.yml. Both need the same fix, tracked separately rather than bundled here.
Separately worth raising upstream: drupal/storybook constraining symfony/css-selector to ^4 || ^6 || ^7 is the underlying incompatibility, and will affect anything pairing Storybook with a Drupal CMS lock.
AI-Generated: Yes
Checkpoints
- File an issue
- Addition / Change / Update / Fix
- Automated unit testing coverage
- Automated functional testing coverage
- Testing to ensure no regression
- UX/UI designer responsibilities
- Readability
- Accessibility
- Performance
- Security
- Developer Documentation
- User Guide Documentation
- Reviewed by a human
- Code review by maintainers
- Full testing and approval
- Credit contributors
- Review with the product owner
- Release notes snippet
- Release