refactor: #3618245 Remove the Drupal CMS wiring script and its composer asset, inline the setup in CI
Issue: https://www.drupal.org/project/horizonaid/issues/3618245
Summary
Removes the Drupal CMS wiring script and its composer asset from the Horizon Aid site template recipe, and inlines what that script did into the one CI job that used it.
The wiring script existed only to prepare a plain Drupal CMS root, and it was never run by the recipe itself, only by the 🧩 (Drupal CMS) Install Horizon Aid site template job. The composer settings it merged are nine composer config calls, short enough to read in the job itself.
The front-end library sync stays. scripts/drupal-libraries-sync.js and scripts/assets/drupal-libraries.package.json are a pair, the script reading the drupal-libraries block the asset declares, so the CI job now places both files itself instead of leaving that to the wiring script.
Changes
Deleted:
scripts/drupal-cms-wiring.phpscripts/assets/drupal-cms.composer.json
.gitlab-ci.yml, in the 🧩 (Drupal CMS) Install Horizon Aid site template job:
- The single
php .../drupal-cms-wiring.phpstep becomes ninecomposer configcalls. Full key parity with the deleteddrupal-cms.composer.json, so the job's own wiring assertion block (allow-plugins x3,minimum-stability: dev,allowed-dependency-patchesx2) passes unchanged. - The two file placements the wiring script also did are now explicit steps: copy
drupal-libraries.package.jsonin aspackage.json, write the.yarnrc.ymlthat keeps Yarn 4 on the node-modules linker (PnP writes nonode_modules/for the sync script to copy from), and copydrupal-libraries-sync.jsin next topackage.jsonwherepostinstallexpects it. - The library steps that follow are unchanged:
corepack yarn install, thedrupal-librariescount assertion, andls web/libraries. - Reworded the job's header comment, which still described the wiring script as a thing that exists.
Everything else in the job is untouched: composer create-project drupal/cms, the path repository, the root composer require vardot/varbase-patches, composer require drupal/horizonaid:@dev --with-all-dependencies, the recipes/horizonaid and web/modules/contrib/canvas checks, composer show, the wiring assertion, the drush site:install drupal_cms_installer installer_site_template_form.add_ons=horizonaid run, and the default-theme check.
Second MR on this issue. MR !57 (merged) removed the vardot/varbase-patches requirement from the recipe's composer.json; this one removes the wiring script that carried it.
AI-Generated: Yes
Checkpoints:
- File an issue
- Addition/Change/Update/Fix
- Testing to ensure no regression
- Automated unit testing coverage
- Automated functional testing coverage
- UX/UI designer responsibilities
- Readability
- Accessibility
- Performance
- Security
- Developer Documentation
- User Guide Documentation
- Reviewed by human
- Code review by maintainers
- Full testing and approval
- Credit contributors
- Review with the product owner
- Release notes snippet
- Release