Skip to content

Issue #3526414: fixes to Drupal 11 console errors caused by invalid content script values

Greg Watsonrequested to merge
issue/h5p-3526414:3526414-d11-console-errors into 2.0.x

Closes #3526414

Problem

A refactor to the way H5P library scripts are passed to drupalSettings resulted in browser console errors and the Game Map interactive no longer working.

Changes

  • The values in $all_js are now checked to make sure that the data value is a string. This avoids passing in a Drupal settings array that broke a function in the Game Map interactive JS code.
  • The paths are also passed through the file_url_generator service's generateAbsoluteString() method to ensure they are absolute paths. Relative pathing breaks the loading of the those files in some cases.

Merge request reports