Skip to content
Snippets Groups Projects

Issue #3399569: Adopt GitLab CI

Merged Naveen Valecha requested to merge issue/group-3399569:3399569-adopt-gitlab-ci into 2.3.x
2 unresolved threads

Closes #3399569

Edited by Naveen Valecha

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
34 34 /**
35 35 * {@inheritdoc}
36 36 */
37 public function getCancelURL() {
37 public function getCancelUrl() {
  • Nikolay Shapovalov
  • 1 1 <?php
    2 // phpcs:ignoreFile
  • Nikolay Shapovalov
  • Nikolay Shapovalov
  • Thanks a lot for MR, most of the changes is very clear, I left some questions, can you please check it.

  • added 1 commit

    • 5b68c855 - Try fixing all of this with a custom phpcs.xml file

    Compare with previous version

  • added 1 commit

    • 8b3a5373 - Try adding a phpstan.neon file to ignore a certain error

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c9cac3f9 - Ignore 2 most common errors for now and add entity mapping

    Compare with previous version

  • added 1 commit

    • 4c8a9152 - Fix a few easy ones and then rely on the baseline for fixing after the fact

    Compare with previous version

  • added 1 commit

    • c4d5d17a - Include baseline so we can get past this step

    Compare with previous version

  • added 1 commit

    • eafbdb77 - Do not skip ESLINT and fix some STYLELINT

    Compare with previous version

  • added 1 commit

    • 025f1413 - Back in the box you, no clue what you're talking about

    Compare with previous version

  • added 1 commit

    • 45bd43a2 - Wrong operator after cleanup

    Compare with previous version

  • Kristiaan Van den Eynde changed target branch from 2.2.x to 2.3.x

    changed target branch from 2.2.x to 2.3.x

  • added 3 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 116a58d1 - Fix phpcs and phpstan a bit more, undo some changes

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 28191f69 - Make sure test goes green on 10.2

    Compare with previous version

  • added 1 commit

    • ed44e7dd - Expand baseline for recent testfix

    Compare with previous version

  • added 1 commit

    • 08261fbd - See if we can ignore all of the prophecy phpstan failures

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • e1f06319 - Reduce baseline and try not specifically relying on phpstan/extension-installer

    Compare with previous version

  • added 1 commit

    • 64d38ca7 - Let's try this according to an issue on github

    Compare with previous version

  • added 1 commit

    • 3ff1ee8e - Further improve typehinting of prophecy

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading