Skip to content
Snippets Groups Projects
Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

This module is not required. It is just a suggested module.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

The return value cannot be defined as ResponseInterface|null when the method returns FALSE.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

As that property is not expected to be changed, it should probably be replaced by a constant....

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

A definite article is missing. The module name is Graph Mail. I don't feel necessary to say it is the Graph Mail's state name.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

That is usually described as the state storage service. There is no need to add Drupal (and API should be spelled in upper-case letters).

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

Doesn't the Key module use annotations for its plugins?

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

Since a form element is by default visible, should not the form element be hidden when the credential provider is not graph_mail?

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

This code verifies the configuration values have been submitted, even when those values are surely submitted.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

This class uses snake case for local variables names.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

The module name is Graph Mail, not graph mail.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

As I said in an issue comment, this is fine, but the Key module should not be a hard dependency.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

This change is out-of-topic for this issue.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

New parameters must be added after the existing ones....

Shivam Tiwari's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

I updated all code please verify now.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

I would avoid a constant that is used only twice.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

This class uses snail case local variable names. That needs to be consistently used.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

Instead of ResponseInterface|bool, it would be better to use ResponseInterface|null.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

As the code has been changed, this is not a suggestion: It is a dependency.

Alberto Paderno's avatar
commented on merge request !42 "Key integration with graph mail." at project / graph_mail

An optional parameter cannot be followed by a required parameter.