Skip to content
Snippets Groups Projects

Push almost all pipeline definition to a new include

All threads resolved!

This lets us make changes and have almost all projects follow along without their intervention.

With this PR an implementing project just puts the following stanza in their .gitlab-ci.yml

include:
  # This include centralizes our CI "golden path" https://docs.gitlab.com/ee/ci/yaml/#includefile
  - project: 'project/gitlab_templates'
    ref: $_GITLAB_TEMPLATES_REF
    file:
      - '/includes/include.drupalci.main.yml'
      - '/includes/include.drupalci.variables.yml'
      - '/includes/include.drupalci.workflows.yml'

This MR also:

  1. Facilitates matrix testing by making it easy to reuse the phpunit job definition.
  2. Makes it possible to disable a job via env variable
  3. Adds --no-interaction to phpunit command
  4. Copies in the default phpcs config
  5. Simplify by not using composer scripts.
  6. Use disclosure triangle to hide printing of env vars in the Console. This tidies our Console log.
  7. Adds Nightwatch testing
  8. Eslint/Stylelint only run when there is work to do
Edited by Moshe Weitzman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • baf11680 - Fix URLs for curl in composer job

    Compare with previous version

  • Moshe Weitzman added 3 commits

    added 3 commits

    • 8c05018d - Use --no-interaction in phpunit call
    • 31ebc667 - Copy default PHPCS config during phpcs job
    • a1b09b49 - Allow skipping a job just by setting an env variable

    Compare with previous version

  • added 1 commit

    • 04c3020e - Facilitate matrix testing in phpunit job

    Compare with previous version

  • Moshe Weitzman changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 6781e4b2 - Simplify a bit by not using composer scripts.

    Compare with previous version

  • Moshe Weitzman changed the description

    changed the description

  • added 1 commit

    • d28fa6e6 - Fix typos in scripts removal

    Compare with previous version

  • added 1 commit

    • b22ef7c0 - Use disclosure to hide env variable printing until needed ... Allow for...

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Moshe Weitzman changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c5148b4f - Our scripts should not be included in phpcs for the project.

    Compare with previous version

  • added 1 commit

    • 13478c30 - Try to fix exclude in artifacts

    Compare with previous version

  • Jürgen Haas
  • Moshe Weitzman added 2 commits

    added 2 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Moshe Weitzman added 3 commits

    added 3 commits

    • 5dcbd6f4 - Use keycdn for downstream testing. Its less volatile and exercises features more
    • 51847dfe - Adds needs[] so that phpunit job runs as soon as possible
    • f26d5007 - Set MINK_DRIVER_ARGS_WEBDRIVER env variable.

    Compare with previous version

  • added 1 commit

    • 6dd92bf9 - Factor composer job into a hidden so it can be easily reused.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Moshe Weitzman changed the description

    changed the description

  • Moshe Weitzman changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 5c3beb42 - Fix artifact path and factor nightwatch a smidge

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 8e8a2196 - Small clean ups to inline documentation and variable descriptions.

    Compare with previous version

  • Moshe Weitzman added 2 commits

    added 2 commits

    Compare with previous version

  • Moshe Weitzman changed the description

    changed the description

  • Tim Hestenes Lehnen resolved all threads

    resolved all threads

  • Tim Hestenes Lehnen started a merge train

    started a merge train

  • Tim Hestenes Lehnen removed this merge request from the merge train because pipeline did not succeed

    removed this merge request from the merge train because pipeline did not succeed

  • Please register or sign in to reply
    Loading