Skip to content
Snippets Groups Projects

#3414505 Set next major core_version_requirement in sub-modules

Merged #3414505 Set next major core_version_requirement in sub-modules
issue/gitlab_templates-3414505:3414505-sub-modules-next-major-compatibility into main
1 unresolved thread
Merged Jonathan Smith requested to merge issue/gitlab_templates-3414505:3414505-sub-modules-next-major-compatibility into main
1 unresolved thread

Closes #3414505

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
includes/include.drupalci.main.yml
106 106 - chown -R www-data:www-data $CI_PROJECT_DIR
107 107 - service apache2 start
108 108
109 # If the module already supports Drupal 11, do nothing, otherwise, claim Drupal 11 support for testing purposes.
110 .amend-core-requirements-drupal-11: &amend-core-requirements-drupal-11
109 # Claim compatibility for the module and all its sub-modules to allow testing at 'Next Major'.
110 .amend-core-requirements-drupal-next-major: &amend-core-requirements-drupal-next-major
  • Fran Garcia-Linares
    Fran Garcia-Linares @fjgarlin
    Maintainer

    We had a very similar thinking in the snippet renaming! See this commit: !242 (2c9c4c6e)

    I ended up calling it amend-core-requimentes-next-major. See the MR here: !242 (diffs)

    I'd say that, if possible, let's keep the same naming here, and then we'll change the naming and usage in the 242 MR.

  • Jonathan Smith
    Jonathan Smith @jonathan1055
    Author Contributor

    I made my change as a consequence of seeing yours in !242 (merged) to keep it in line and avoid a conflict. I used your original name amend-core-requirements-drupal-next-major so I guess you later shortened that.

    I'd say that, if possible, let's keep the same naming here,

    OK, do you mean revert the change I made here, so that we do not change the name until !242 (merged) ?

    Edited by Jonathan Smith
  • Fran Garcia-Linares
    Fran Garcia-Linares @fjgarlin
    Maintainer

    Yeah, I shortened it a bit because eslint wasn't happy, but I thought the shortened version was ok as well.

    I'd say either revert it and we deal with the name change in !242 (merged), or if you want to keep it here, then let's match the name and the deprecation job and I can sort the conflict in the other one.

    I don't want to derail too much this issue, that's why I suggested a revert, but feel free to do whatever is more comfortable/easier for you, I'm happy either way as we are both likely to review both issues.

  • Jonathan Smith
    Jonathan Smith @jonathan1055
    Author Contributor

    ah, I had not see the deprecation job. No need to add that in this mr, therefore I will revert the change I did, so that it is cleaner and clearer in !242 (merged)

  • Jonathan Smith changed this line in version 14 of the diff

    changed this line in version 14 of the diff

  • Please register or sign in to reply
  • Jonathan Smith added 2 commits

    added 2 commits

    • d303540c - Only change if the row does not have ^11. Also add to the end, not remove...
    • 5060c366 - Revert change of name

    Compare with previous version

  • Fran Garcia-Linares
  • Jonathan Smith added 1 commit

    added 1 commit

    • 0a644b0c - Only check for existence of 11 not ^11 when detecting lines to edit

    Compare with previous version

  • Fran Garcia-Linares added 1 commit

    added 1 commit

    • 23f0602b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Fran Garcia-Linares merged

    merged

    • Please register or sign in to reply