Skip to content
Snippets Groups Projects

Fix eslint and prettier

Merged Fix eslint and prettier
eslint-prettier into 1.0.x
All threads resolved!
Merged Moshe Weitzman requested to merge eslint-prettier into 1.0.x
All threads resolved!

Fixes https://www.drupal.org/project/gitlab_templates/issues/3357971.

The eslint findings in keycdn are either legit or we havent configured eslint just right. I'm unsure. I copied block.js from Drupal core's block module and that's where the eslint findings are being reported.

In any case, this is an improvement over where eslint was so IMO we should merge.

Edited by Moshe Weitzman

Merge request reports

Merged results pipeline #11216 passed

Stage: test
Pipeline: keycdn

#11217

    Merged results pipeline passed for b3548334

    Merged by Tim Hestenes LehnenTim Hestenes Lehnen 2 years ago (May 4, 2023 8:12pm UTC)

    Loading

    Pipeline #11232 skipped

    Stage: test

    Pipeline skipped for 6d5113c6 on 1.0.x

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Moshe Weitzman added 1 commit

    added 1 commit

    • d6d2b3cc - Document how projects can help test MRs in gitlab_templates.

    Compare with previous version

  • Tim Hestenes Lehnen merged

    merged

  • Tim Hestenes Lehnen resolved all threads

    resolved all threads

    • Please register or sign in to reply