Issue #3431269 by fjgarlin, longwave: Yarn install fails in "composer (next major)" job

CHANGELOG.md

 # GitLab Templates Changelog
 
+## 1.3.1 - 2024-03-19
+
+#3431269 - Yarn install fails in "composer (next major)" job.\
+#3419008 - Add logic to avoid running PHPUnit if the project has no phpunit tests.
+
 ## 1.3.0 - 2024-03-14
 
 #3426647 - Check our own coding standards and basic editor configurations.\

assets/internal/.spelling

@@ -64,6 +64,7 @@ browsertest
 codequality
 codesniffer
 consitent
+corepack
 ctools
 curlopt
 cweagans

includes/include.drupalci.main.yml

@@ -294,7 +294,7 @@ stages:
         mv composer.json.backup $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME/composer.json
       fi
     # For Nightwatch et al.
-    - yarn --cwd $_WEB_ROOT/core install
+    - cd $_WEB_ROOT/core && corepack enable && yarn install && cd $CI_PROJECT_DIR
     - touch $_WEB_ROOT/core/.env
     # Display any deprecation warning which may have been set.
     - printf "$_DEPRECATION_MESSAGE"
@@ -487,7 +487,7 @@ stylelint:
   needs:
     - composer
   script:
-    - yarn --cwd $_WEB_ROOT/core add stylelint-junit-formatter
+    - cd $_WEB_ROOT/core && corepack enable && yarn add stylelint-junit-formatter
     # Change directory to the project root folder.
     - cd $CI_PROJECT_DIR/$_WEB_ROOT/modules/custom/$CI_PROJECT_NAME
     - echo "STYLELINT version $(${CI_PROJECT_DIR}/${_WEB_ROOT}/core/node_modules/.bin/stylelint --version)"
@@ -672,12 +672,13 @@ cspell:
     - echo "DRUPAL_TEST_WEBDRIVER_CHROME_ARGS='--disable-dev-shm-usage --disable-gpu --headless'" >> ./core/.env
     - echo "DRUPAL_TEST_WEBDRIVER_PORT='9515'" >> ./core/.env
     - cat ./core/.env
-    - mkdir -p ./sites/simpletest ./sites/default/files /var/www/.cache/yarn /var/www/.yarn ./core/reports
-    - chown -R www-data:www-data ./sites/simpletest ./sites/default/files /var/www/.cache/yarn /var/www/.yarn ./core/reports ./core/.env
+    - mkdir -p ./sites/simpletest ./sites/default/files /var/www/.cache/yarn /var/www/.yarn ./core/reports /var/www/.cache/node /var/www/.cache/corepack /var/www/.node/corepack
+    - chown -R www-data:www-data ./sites/simpletest ./sites/default/files /var/www/.cache/yarn /var/www/.yarn ./core/reports ./core/.env /var/www/.cache/node /var/www/.cache/corepack /var/www/.node/corepack
     - $CI_PROJECT_DIR/$_WEB_ROOT/core/node_modules/.bin/nightwatch --version
-    # @todo Uncomment this line and remove the line after it once https://www.drupal.org/project/drupal/issues/3389763 lands.
-    # - sudo BABEL_DISABLE_CACHE=1 DRUPAL_NIGHTWATCH_SEARCH_DIRECTORY=modules/custom/ -u www-data yarn --cwd ./core test:nightwatch
-    - sudo BABEL_DISABLE_CACHE=1 -u www-data yarn --cwd ./core test:nightwatch --tag=${CI_PROJECT_NAME%-*}
+    # @todo Run per-directory: https://www.drupal.org/project/drupal/issues/3389763
+    # - Add DRUPAL_NIGHTWATCH_SEARCH_DIRECTORY=modules/custom/ to the below.
+    - cd core && corepack enable && sudo BABEL_DISABLE_CACHE=1 -u www-data yarn test:nightwatch --tag=${CI_PROJECT_NAME%-*}
+
   artifacts:
     expire_in: 6 mos
     expose_as: reports