Skip to content
Snippets Groups Projects

Gin Settings Using static text that does not support translation.

Open Gin Settings Using static text that does not support translation.
issue/gin-3508553:3508553-gin-settings-using into 4.0.x
19 unresolved threads
Open Shivam Tiwari requested to merge issue/gin-3508553:3508553-gin-settings-using into 4.0.x
19 unresolved threads

Closes #3508553

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #457379 passed

Stage: build
Stage: test

Merge request pipeline passed for c08d9ee1

Approval is optional
Test summary results are being parsed
Full report
Merge blocked: 1 check failed
The change requests must be completed or resolved.

Merge details

  • The source branch is 4 commits behind the target branch.
  • 1 commit will be added to 4.0.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinContentFormHelper.php
    138 138 ];
    139 139
    140 140 // Create gin_more_actions group.
    141 $toggle_more_actions = t('More actions');
    141 $toggle_more_actions = $this->t('More actions');
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinAfterBuild.php
    33 33 $value = $element['#options'][$value];
    34 34 }
    35 35 if ($element['#type'] === 'checkbox') {
    36 $value = $value ? t('Enabled') : t('Disabled');
    36 $value = $value ? $this->t('Enabled') : $this->t('Disabled');
    37 37 }
    38 38
    39 39 $element += ['#description' => ''];
    40 40 $element['#description'] .= '<span class="form-item__warning">' .
    41 t('This setting is overridden by the <a href=":editUrl">current user</a>. @title: %value',
    41 $this->t('This setting is overridden by the <a href=":editUrl">current user</a>. @title: %value',
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinAfterBuild.php
    33 33 $value = $element['#options'][$value];
    34 34 }
    35 35 if ($element['#type'] === 'checkbox') {
    36 $value = $value ? t('Enabled') : t('Disabled');
    36 $value = $value ? $this->t('Enabled') : $this->t('Disabled');
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinContentFormHelper.php
    222 222 // Action buttons.
    223 223 if (isset($form['actions'])) {
    224 224 // Add sidebar toggle.
    225 $hide_panel = t('Hide sidebar panel');
    225 $hide_panel = $this->t('Hide sidebar panel');
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinContentFormHelper.php
    245 245 $form['gin_sidebar']['footer'] = ($form['footer']) ?? [];
    246 246
    247 247 // Sidebar close button.
    248 $close_sidebar_translation = t('Close sidebar panel');
    248 $close_sidebar_translation = $this->t('Close sidebar panel');
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    54 54 // Remove content and help from admin menu.
    55 55 unset($build['#items']['system.admin_content']);
    56 56 unset($build['#items']['help.main']);
    57 $build['#title'] = t('Administration');
    57 $build['#title'] = $this->t('Administration');
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    68 68 $shortcuts = \Drupal::service('shortcut.lazy_builders')->lazyLinks()['shortcuts'];
    69 69 $shortcuts['#theme'] = 'menu_region__top';
    70 70 $shortcuts['#menu_name'] = 'bookmarks';
    71 $shortcuts['#title'] = t('Bookmarks');
    71 $shortcuts['#title'] = $this->t('Bookmarks');
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    122 122 $create_type_items,
    123 123 [
    124 124 [
    125 'title' => t('Blocks'),
    125 'title' => $this->t('Blocks'),
  • Sascha Eggenberger requested changes

    requested changes

  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    262 262 $user_items = [
    263 263 [
    264 'title' => t('Profile'),
    264 'title' => $this->t('Profile'),
    265 265 'class' => 'profile',
    266 266 'url' => Url::fromRoute('user.page')->toString(),
    267 267 ],
    268 268 [
    269 'title' => t('Settings'),
    269 'title' => $this->t('Settings'),
    270 270 'class' => 'settings',
    271 271 'url' => Url::fromRoute('entity.user.admin_form')->toString(),
    272 272 ],
    273 273 [
    274 'title' => t('Log out'),
    274 'title' => $this->t('Log out'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    148 148 $create_type_items,
    149 149 [
    150 150 [
    151 'title' => t('Media'),
    151 'title' => $this->t('Media'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    174 174 $create_type_items,
    175 175 [
    176 176 [
    177 'title' => t('Taxonomy'),
    177 'title' => $this->t('Taxonomy'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    214 214 // Get Content menu item.
    215 215 if ($entity_type_manager->hasDefinition('node')) {
    216 216 $create_content_items['content'] = [
    217 'title' => t('Content'),
    217 'title' => $this->t('Content'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    223 223 // Get Blocks menu item.
    224 224 if ($entity_type_manager->hasDefinition('block_content')) {
    225 225 $create_content_items['blocks'] = [
    226 'title' => t('Blocks'),
    226 'title' => $this->t('Blocks'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    232 232 // Get File menu item.
    233 233 if ($entity_type_manager->hasDefinition('file')) {
    234 234 $create_content_items['files'] = [
    235 'title' => t('Files'),
    235 'title' => $this->t('Files'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    241 241 // Get Media menu item.
    242 242 if ($entity_type_manager->hasDefinition('media')) {
    243 243 $create_content_items['media'] = [
    244 'title' => t('Media'),
    244 'title' => $this->t('Media'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    251 251 '#theme' => 'menu_region__middle',
    252 252 '#items' => $create_content_items,
    253 253 '#menu_name' => 'content',
    254 '#title' => t('Content Navigation'),
    254 '#title' => $this->t('Content Navigation'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    261 261 public function getMenuNavigationUserItems(): array {
    262 262 $user_items = [
    263 263 [
    264 'title' => t('Profile'),
    264 'title' => $this->t('Profile'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    261 261 public function getMenuNavigationUserItems(): array {
    262 262 $user_items = [
    263 263 [
    264 'title' => t('Profile'),
    264 'title' => $this->t('Profile'),
    265 265 'class' => 'profile',
    266 266 'url' => Url::fromRoute('user.page')->toString(),
    267 267 ],
    268 268 [
    269 'title' => t('Settings'),
    269 'title' => $this->t('Settings'),
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinNavigation.php
    280 280 '#theme' => 'menu_region__bottom',
    281 281 '#items' => $user_items,
    282 282 '#menu_name' => 'user',
    283 '#title' => t('User'),
    283 '#title' => $this->t('User'),
  • Sascha Eggenberger requested changes

    requested changes

  • Shivam Tiwari added 1 commit

    added 1 commit

    • c08d9ee1 - Updated files according to comments.

    Compare with previous version

    • Please register or sign in to reply