Skip to content
Snippets Groups Projects

Resolve #3500065 "Invalid aria attributes"

Open Resolve #3500065 "Invalid aria attributes"
issue/gin-3500065:3500065-invalid-aria-attributes into 4.0.x
3 unresolved threads
Open SOURABH SISODIA requested to merge issue/gin-3500065:3500065-invalid-aria-attributes into 4.0.x
3 unresolved threads

Closes #3500065

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #476607 passed

Stage: build
Stage: validate
Stage: test

Merge request pipeline passed for 00030258

Code Quality is loading
Test summary results are being parsed
Full report
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/GinContentFormHelper.php
139 139
140 140 // Create gin_more_actions group.
141 141 $toggle_more_actions = t('More actions');
142 $menu_id = 'gin-more-actions-' . uniqid();
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinContentFormHelper.php
    147 149 'class' => ['gin-more-actions'],
    148 150 ],
    149 151 'more_actions_toggle' => [
    150 '#markup' => '<a href="#toggle-more-actions" class="gin-more-actions__trigger trigger" data-gin-tooltip role="button" title="' . $toggle_more_actions . '" aria-controls="gin_more_actions"><span class="visually-hidden">' . $toggle_more_actions . '</span></a>',
    152 '#markup' => '<a href="#toggle-more-actions" class="gin-more-actions__trigger trigger" data-gin-tooltip role="button" title="' . $toggle_more_actions . '" aria-controls="' . $menu_id . '"><span class="visually-hidden">' . $toggle_more_actions . '</span></a>',
    • Sascha Eggenberger
      Sascha Eggenberger @saschaeggi
      Maintainer
      Suggested change
      123 '#markup' => '<a href="#toggle-more-actions" class="gin-more-actions__trigger trigger" data-gin-tooltip role="button" title="' . $toggle_more_actions . '" aria-controls="' . $menu_id . '"><span class="visually-hidden">' . $toggle_more_actions . '</span></a>',
      123 '#markup' => '<a href="#toggle-more-actions" class="gin-more-actions__trigger trigger" data-gin-tooltip role="button" title="' . $toggle_more_actions . '" aria-controls="' . $actions_menu_id . '"><span class="visually-hidden">' . $toggle_more_actions . '</span></a>',
    • Boris Doesborg changed this line in version 4 of the diff

      changed this line in version 4 of the diff

    • Boris Doesborg
      Boris Doesborg @batigolix

      done

    • Please register or sign in to reply
  • Sascha Eggenberger
    Sascha Eggenberger @saschaeggi started a thread on an old version of the diff
    • src/GinContentFormHelper.php
    147 149 'class' => ['gin-more-actions'],
    148 150 ],
    149 151 'more_actions_toggle' => [
    150 '#markup' => '<a href="#toggle-more-actions" class="gin-more-actions__trigger trigger" data-gin-tooltip role="button" title="' . $toggle_more_actions . '" aria-controls="gin_more_actions"><span class="visually-hidden">' . $toggle_more_actions . '</span></a>',
    152 '#markup' => '<a href="#toggle-more-actions" class="gin-more-actions__trigger trigger" data-gin-tooltip role="button" title="' . $toggle_more_actions . '" aria-controls="' . $menu_id . '"><span class="visually-hidden">' . $toggle_more_actions . '</span></a>',
    151 153 '#weight' => 1,
    152 154 ],
    153 155 'more_actions_items' => [
    154 156 '#type' => 'container',
    155 157 '#multilingual' => TRUE,
    158 '#attributes' => [
    159 'id' => $menu_id,
  • Sascha Eggenberger requested changes

    requested changes

  • Boris Doesborg added 7 commits

    added 7 commits

    Compare with previous version

  • Boris Doesborg added 1 commit

    added 1 commit

    Compare with previous version

  • Boris Doesborg added 1 commit

    added 1 commit

    • 00030258 - Improve aria control attribute

    Compare with previous version

    • Please register or sign in to reply