Fix sticky table header for views in a block (!512) · Merge requests · project / gin · GitLab

Snippets Groups Projects

Open Jürgen Haas requested to merge issue/gin-3474245:3474245-sticky-header-in-views-block into 8.x-3.x 6 months ago

1 unresolved thread

Closes #3474245

Activity

Laurent Bekaert added 1 commit 6 months ago
added 1 commit

3fc2d4bd - Fix for sticky table headers

Compare with previous version
Laurent Bekaert added 1 commit 6 months ago
added 1 commit

3a96ac60 - npm build iso of dev

Compare with previous version
Laurent Bekaert added 8 commits 6 months ago
added 8 commits

3a96ac60...f9d8d3c3 - 7 commits from branch project:8.x-3.x

10e0289d - Merge branch '8.x-3.x' into '3474245-sticky-header-in-views-block'

Compare with previous version
Sascha Eggenberger @saschaeggi started a thread on the diff 5 months ago

styles/base/_table.scss

1

1

.gin-table-scroll-wrapper {

2

2

clear: both;

3

overflow-x: auto;

4

overflow-y: hidden;

Comment on lines -3 to -4

Sascha Eggenberger @saschaeggi · 5 months ago

Maintainer

This unfortunately will break the existing implementation:

This MR upstream
Sascha Eggenberger @saschaeggi · 5 months ago

Maintainer

The bottom border is missing:

This MR upstream
Laurent Bekaert @selfirian · 5 months ago

Thanks for the feedback. I saw the bottom border missing, no idea why I have to dig a bit into it. Same for the the overflow, I don't seem to have that issue on firefox so I have to check it on other browsers I guess.
Please register or sign in to reply

Please register or sign in to reply