Skip to content
Snippets Groups Projects

Improve hardcoding #group for the status field

Merged paul121 requested to merge issue/gin-3440148:3440148-only-status-content-form into 8.x-3.x
1 unresolved thread

Closes #3440148

Merge request reports

Merge train pipeline #372178 passed

Merge train pipeline passed for 98e131e6

Approval is optional
Test summary results are being parsed

Merged by Sascha EggenbergerSascha Eggenberger 5 months ago (Dec 18, 2024 7:53am UTC)

Merge details

  • Changes merged into 8.x-3.x with 98e131e6.
  • Did not delete the source branch.
  • Auto-merge enabled

Pipeline #372185 passed

Pipeline passed for 98e131e6 on 8.x-3.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The diff for this commit is a bit ugly, but its not that complicated. This collapses the nested if statements into a single if statement and saves the conditions to a variable so they can be reused later on. Much of the diff is un-indenting all of the logic from the nested if statement.

  • Please register or sign in to reply
  • paul121 added 32 commits

    added 32 commits

    • 496ffb3f...996a9afd - 29 commits from branch project:8.x-3.x
    • cf5b4278 - Only alter the status field on content forms
    • 416dddde - Only move status to status group if it is a checkbox
    • 9c9f75c8 - Improve content form logic and remove nested if statement

    Compare with previous version

  • paul121 added 2 commits

    added 2 commits

    • 040cd871 - Remove nested if statement
    • dcfe0e14 - Save form types and behaviors to variables

    Compare with previous version

  • Please register or sign in to reply
    Loading